diff --git a/src/convergence.jl b/src/convergence.jl index 82217b1..f7f3ef9 100644 --- a/src/convergence.jl +++ b/src/convergence.jl @@ -278,7 +278,11 @@ function assess_convergence(M::Any, state::AbstractUnivariateZeroState, options) return (:not_converged, false) end -function assess_convergence(M::AbstractBisection, state::AbstractUnivariateZeroState, options::O) where {O <: Union{ExactOptions, XExactOptions}} +function assess_convergence( + M::AbstractBisection, + state::AbstractUnivariateZeroState, + options::O, +) where {O<:Union{ExactOptions,XExactOptions}} # return convergence_flag, boolean # no check if f == ∞ is_exact_zero_f(M, state, options) && return (:exact_zero, true) @@ -288,7 +292,6 @@ function assess_convergence(M::AbstractBisection, state::AbstractUnivariateZeroS return (:not_converged, false) end - # speeds up exact f values by just a bit (2% or so) over the above, so guess this is worth it. function assess_convergence( M::AbstractBracketingMethod, diff --git a/test/test_find_zero.jl b/test/test_find_zero.jl index 9e550be..6d7757f 100644 --- a/test/test_find_zero.jl +++ b/test/test_find_zero.jl @@ -587,9 +587,9 @@ end @testset "bracketing_atol" begin ## issue $457 f(x) = x^2 - 4 - @test find_zero(f, (0,Inf)) ≈ 2 # 2.0 correct - @test find_zero(f, (0,Inf), atol=1) ≈ 1.9997558593749998 - @test find_zero(f, (0,Inf),atol=1e-5) ≈ 1.9999998807907102 - @test find_zero(f, (0,8), atol=1) ≈ 1.99609375 - @test find_zero(f, (0,8), atol=1e-3) ≈ 2.0000152587890625 + @test find_zero(f, (0, Inf)) ≈ 2 # 2.0 correct + @test find_zero(f, (0, Inf), atol=1) ≈ 1.9997558593749998 + @test find_zero(f, (0, Inf), atol=1e-5) ≈ 1.9999998807907102 + @test find_zero(f, (0, 8), atol=1) ≈ 1.99609375 + @test find_zero(f, (0, 8), atol=1e-3) ≈ 2.0000152587890625 end