Skip to content

Commit 3266cfa

Browse files
committed
add broker interface env var name
1 parent ec3f988 commit 3266cfa

File tree

2 files changed

+30
-26
lines changed

2 files changed

+30
-26
lines changed

src/NetworkInterfaceControllers.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,24 @@ export get_interface_data
88

99
include("broker.jl")
1010
using .Broker
11+
export Broker
1112
export start_server, query
1213

1314
include("nic_preferences.jl")
1415
using .NICPreferences
16+
export NICPreferences
1517

1618
include("name_selector.jl")
1719
using .NameSelector
20+
export NameSelector
1821

1922
# Load HwlocSelector module via and extension => avoid adding dependencies on
2023
# Hwloc and AbstractTrees unless needed
2124
get_hwloc_selector() = Base.get_extension(@__MODULE__, :HwlocSelector)
2225

2326
include("hostlists.jl")
2427
using .Hostlists
28+
export Hostlists
2529

2630
#------------------------------------------------------------------------------
2731
# Helper functions for Broker
@@ -117,7 +121,6 @@ function best_interface_broker(
117121
broker_addr = "localhost"
118122
for env_add in NICPreferences.BROKER_HOST_ENV
119123
end
120-
121124
end
122125

123126
function best_interfaces(data::Vector{Interface})

src/nic_preferences.jl

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ mutable struct InterfaceSettings
150150
end
151151

152152

153-
const _name_selector_mode_default = setting(:mode, USE_ALWAYS)
153+
const _name_selector_mode_default = setting(:mode, USE_ALWAYS)
154154
const _preferred_interface_default = setting(:interface, ".*", MATCH_REGEX)
155-
const _name_selector_mode = @load_preference("name_selector_mode")
155+
const _name_selector_mode = @load_preference("name_selector_mode")
156156
const _preferred_interface = @load_preference("preferred_interface")
157157

158158
const INTERFACE_NAME_BLACKLIST = @load_preference("interface_name_blacklist")
@@ -161,22 +161,22 @@ const INTERFACE_NAME_WHITELIST = @load_preference("interface_name_whitelist")
161161
const _hwloc_selector_mode_default = setting(:mode, USE_DISABLED)
162162
const _hwloc_nic_pci_class_default = "Ethernet"
163163
const _hwloc_selector_mode = @load_preference("hwloc_selector_mode")
164-
const HWLOC_NIC_PCI_CLASS = @load_preference(
164+
const HWLOC_NIC_PCI_CLASS = @load_preference(
165165
"hwloc_nic_pci_class", _hwloc_nic_pci_class_default
166166
)
167167

168-
const _broker_mode_default = setting(:mode, USE_DISABLED)
168+
const _broker_mode_default = setting(:mode, USE_DISABLED)
169169
const _broker_interface_default = setting(:interface, ".*", MATCH_REGEX, 3000)
170-
const _broker_mode = @load_preference("broker_mode")
170+
const _broker_mode = @load_preference("broker_mode")
171171
const _broker_interface = @load_preference("broker_interface")
172-
const BORKER_HOST_ENV = @load_preference("broker_host_env", [])
172+
const BORKER_HOST_ENV = @load_preference("broker_host_env", [])
173173

174-
const NAME_SELECTOR = ModeSettings(@val_or_default(:_name_selector_mode))
174+
const NAME_SELECTOR = ModeSettings(@val_or_default(:_name_selector_mode))
175175
const HWLOC_SELECTOR = ModeSettings(@val_or_default(:_hwloc_selector_mode))
176-
const BROKER = ModeSettings(@val_or_default(:_broker_mode))
176+
const BROKER = ModeSettings(@val_or_default(:_broker_mode))
177177

178178
const PREFERRED_INTERFACE = InterfaceSettings(@val_or_default(:_preferred_interface))
179-
const BROKER_INTERFACE = InterfaceSettings(@val_or_default(:_broker_interface))
179+
const BROKER_INTERFACE = InterfaceSettings(@val_or_default(:_broker_interface))
180180

181181
export NAME_SELECTOR, HWLOC_SELECTOR, BROKER
182182
export INTERFACE_NAME_BLACKLIST, INTERFACE_NAME_WHITELIST
@@ -191,15 +191,15 @@ end
191191
return in_list
192192

193193
function configure!(;
194-
name_selector_mode::Dict{String, Any}=_name_selector_mode_default,
195-
preferred_interface::Dict{String, Any}=_preferred_interface_default,
196-
interface_name_whitelist::Union{Vector{String}, Nothing}=nothing,
197-
interface_name_blacklist::Union{Vector{String}, Nothing}=nothing,
198-
hwloc_selector_mode::Dict{String, Any}=_hwloc_selector_mode_default,
199-
hwloc_nic_pci_class::Union{String, Nothing}=_hwloc_nic_pci_class_default,
200-
broker_mode::Dict{String, Any}=_broker_mode_default,
201-
broker_interface::Dict{String, Any}=_broker_interface_default,
202-
broker_host_env::Union{Vector{String}, Nothing}=nothing
194+
name_selector_mode::Dict{String, Any} = _name_selector_mode_default,
195+
preferred_interface::Dict{String, Any} = _preferred_interface_default,
196+
interface_name_whitelist::Union{Vector{String}, Nothing} = nothing,
197+
interface_name_blacklist::Union{Vector{String}, Nothing} = nothing,
198+
hwloc_selector_mode::Dict{String, Any} = _hwloc_selector_mode_default,
199+
hwloc_nic_pci_class::Union{String, Nothing} = _hwloc_nic_pci_class_default,
200+
broker_mode::Dict{String, Any} = _broker_mode_default,
201+
broker_interface::Dict{String, Any} = _broker_interface_default,
202+
broker_host_env::Union{Vector{String}, Nothing} = nothing
203203
)
204204

205205
@assert check_mode(name_selector_mode)
@@ -209,16 +209,17 @@ function configure!(;
209209
@assert check_interface(preferred_interface)
210210
@assert check_interface(broker_interface)
211211

212+
println(broker_host_env)
212213
@set_preferences!(
213-
"name_selector_mode" => name_selector_mode,
214-
"preferred_interface" => preferred_interface,
214+
"name_selector_mode" => name_selector_mode,
215+
"preferred_interface" => preferred_interface,
215216
"interface_name_whitelist" => interface_name_whitelist,
216217
"interface_name_blacklist" => interface_name_blacklist,
217-
"hwloc_selector_mode" => hwloc_selector_mode,
218-
"hwloc_nic_pci_class" => hwloc_nic_pci_class,
219-
"broker_mode" => broker_mode,
220-
"broker_interface" => broker_interface,
221-
"broker_host_env" => broker_host_env
218+
"hwloc_selector_mode" => hwloc_selector_mode,
219+
"hwloc_nic_pci_class" => hwloc_nic_pci_class,
220+
"broker_mode" => broker_mode,
221+
"broker_interface" => broker_interface,
222+
"broker_host_env" => broker_host_env
222223
)
223224
end
224225

0 commit comments

Comments
 (0)