Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve test env #17

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

Beforerr
Copy link
Member

  • seperate test env as it is recommend
  • remove CondaPkg.toml as we do not want to resolve it globally and make root directory clean

- seperate test env as it is recommend
- remove CondaPkg.toml as we do not want to resolve it globally
@adamslc
Copy link
Member

adamslc commented Feb 1, 2025

Thanks, can you explain more why removing CondaPkg.toml is necessary?

@Beforerr
Copy link
Member Author

Beforerr commented Feb 1, 2025

If you are developing other packages using CondaPkg, the resolver resolves any findable "CondaPkg.toml" all together and they will interfere with each other.

Since we use "CondaPkg.toml" only for test, I prefer to keep it clean

@adamslc adamslc merged commit dc9f4d6 into JuliaPlasma:main Feb 6, 2025
3 checks passed
@adamslc
Copy link
Member

adamslc commented Feb 6, 2025

I'm a little worried that this will mess up the conda pkg caching, but I merged and we can keep an eye on CI times. Thanks!

@Beforerr Beforerr deleted the test-project branch February 10, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants