-
Notifications
You must be signed in to change notification settings - Fork 17
v0.7.17 broke multi-threaded CI of Trixi.jl #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you have a link to a failed CI run? I'm surprised that #154 causes issues, as it only removed errors in |
CI passes with the old version of Polyester.jl in trixi-framework/Trixi.jl#2408 |
That's odd. It just says "operation canceled", as if it was interrupted by GitHub somehow. |
Yes, nothing happened, and the jobs were canceled after 6 hours (the usual limit of GitHub actions). This occurred for all CI runs I examined. |
Ah, now I understand. So freezing threads is the problem then. |
Apparently inside |
Can you please try this branch? |
I created trixi-framework/Trixi.jl#2411 to test your fix |
I prepared a proper fix in #160 and JuliaSIMD/ThreadingUtilities.jl#58. |
Thanks! Let's wait for the other PR to be merged first. |
See some discussion in trixi-framework/Trixi.jl#2408. The only change in behavior in Polyester.jl between v0.7.16 and v0.7.17 is due to #154.
The text was updated successfully, but these errors were encountered: