Skip to content

v0.7.17 broke multi-threaded CI of Trixi.jl #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ranocha opened this issue May 20, 2025 · 11 comments · Fixed by #160
Closed

v0.7.17 broke multi-threaded CI of Trixi.jl #159

ranocha opened this issue May 20, 2025 · 11 comments · Fixed by #160
Labels
bug Something isn't working

Comments

@ranocha
Copy link
Member

ranocha commented May 20, 2025

See some discussion in trixi-framework/Trixi.jl#2408. The only change in behavior in Polyester.jl between v0.7.16 and v0.7.17 is due to #154.

@ranocha ranocha added the bug Something isn't working label May 20, 2025
@efaulhaber
Copy link
Contributor

efaulhaber commented May 20, 2025

Do you have a link to a failed CI run? I'm surprised that #154 causes issues, as it only removed errors in reset_threads!. The main change was JuliaSIMD/ThreadingUtilities.jl#54.

@ranocha
Copy link
Member Author

ranocha commented May 20, 2025

CI passes with the old version of Polyester.jl in trixi-framework/Trixi.jl#2408

@efaulhaber
Copy link
Contributor

That's odd. It just says "operation canceled", as if it was interrupted by GitHub somehow.

@ranocha
Copy link
Member Author

ranocha commented May 20, 2025

Yes, nothing happened, and the jobs were canceled after 6 hours (the usual limit of GitHub actions). This occurred for all CI runs I examined.

@efaulhaber
Copy link
Contributor

Ah, now I understand. So freezing threads is the problem then.

@efaulhaber
Copy link
Contributor

Apparently inside reset_threads!.

@efaulhaber
Copy link
Contributor

Can you please try this branch?
https://github.com/efaulhaber/Polyester.jl/tree/reset-if-task-failed

@ranocha
Copy link
Member Author

ranocha commented May 21, 2025

I created trixi-framework/Trixi.jl#2411 to test your fix

@efaulhaber
Copy link
Contributor

I prepared a proper fix in #160 and JuliaSIMD/ThreadingUtilities.jl#58.

@ranocha
Copy link
Member Author

ranocha commented May 21, 2025

Thanks! Let's wait for the other PR to be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants