Handle issues with Travis/Appveyor having old builds of Julia, without coalesce => something change

Author: ScottPJones

.travis.yml

@@ -13,9 +13,9 @@ git:
 
 ## uncomment the following lines to allow failures on nightly julia
 ## (tests will run but not make your overall status red)
-matrix:
-  allow_failures:
-  - julia: nightly
+#matrix:
+#  allow_failures:
+#  - julia: nightly
 
 ## uncomment and modify the following lines to manually install system packages
 #addons:
@@ -27,9 +27,9 @@ matrix:
 
 ## uncomment the following lines to override the default test script
 script:
-  - julia -e 'VERSION < v"0.7.0-DEV" || (using Pkg) ; if VERSION < v"0.7.0-DEV.5183" ; Pkg.clone(pwd()) ; else ; Pkg.up() ; end ; Pkg.test("ModuleInterfaceTools"; coverage=true)'
+  - julia -e 'if VERSION < v"0.7.0-DEV.5183" ; Pkg.clone(pwd()) ; else ; Pkg.up() ; end ; Pkg.test("ModuleInterfaceTools"; coverage=true)'
 after_success:
   # push coverage results to Coveralls
-  - julia -e 'VERSION < v"0.7.0-DEV" || (using Pkg); cd(Pkg.dir("ModuleInterfaceTools")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(Coveralls.process_folder())'
+  - julia -e 'cd(Pkg.dir("ModuleInterfaceTools")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(Coveralls.process_folder())'
   # push coverage results to Codecov
-  - julia -e 'VERSION < v"0.7.0-DEV" || (using Pkg); cd(Pkg.dir("ModuleInterfaceTools")); Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())'
+  - julia -e 'cd(Pkg.dir("ModuleInterfaceTools")); Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())'

appveyor.yml

@@ -7,10 +7,10 @@ environment:
 
 ## uncomment the following lines to allow failures on nightly julia
 ## (tests will run but not make your overall status red)
-matrix:
-  allow_failures:
-  - JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x86/julia-latest-win32.exe"
-  - JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x64/julia-latest-win64.exe"
+#matrix:
+#  allow_failures:
+#  - JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x86/julia-latest-win32.exe"
+#  - JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x64/julia-latest-win64.exe"
 
 branches:
   only:
@@ -40,11 +40,11 @@ install:
 build_script:
 # Need to convert from shallow to complete for Pkg.clone to work
   - IF EXIST .git\shallow (git fetch --unshallow)
-  - C:\projects\julia\bin\julia -e "VERSION < v\"0.7.0-DEV\" || (using Pkg, InteractiveUtils);
+  - C:\projects\julia\bin\julia -e "VERSION < v\"0.7.0-DEV\" || (using InteractiveUtils);
       versioninfo();
       if VERSION < v\"0.7.0-DEV.5183\";
           Pkg.clone(pwd(), \"ModuleInterfaceTools\");
       else; Pkg.up(); end"
 
 test_script:
-  - C:\projects\julia\bin\julia -e "VERSION < v\"0.7.0-DEV\" || (using Pkg); Pkg.test(\"ModuleInterfaceTools\")"
+  - C:\projects\julia\bin\julia -e "Pkg.test(\"ModuleInterfaceTools\")"

src/ModuleInterfaceTools.jl

@@ -117,8 +117,8 @@ const _cmduse = (:use, :test, :extend, :export, :list)
 const _cmdadd =
     (:modules, :public, :develop, :public!, :develop!, :base, :base!)
 
-@static V6_COMPAT && (const _ff = findfirst)
-@static V6_COMPAT || (_ff(lst, val) = something(findfirst(isequal(val), lst), 0))
+@static V6_COMPAT ? (const _ff = findfirst) :
+    (_ff(lst, val) = (ret = findfirst(isequal(val), lst); ret === nothing ? 0 : ret))
 
 function _add_def!(curmod, grp, exp)
     debug[] && print("_add_def!($curmod, $grp, $exp::$(typeof(exp))")