Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic functionality #1

Open
27 of 42 tasks
aytekinar opened this issue Nov 4, 2016 · 6 comments
Open
27 of 42 tasks

Basic functionality #1

aytekinar opened this issue Nov 4, 2016 · 6 comments

Comments

@aytekinar
Copy link

aytekinar commented Nov 4, 2016

Description

Below is a set of basic functionality needed:

  • c2d,
  • d2c,
  • simulate,
  • impulse,
  • step (SystemsBase.jl),
  • additional signals (SystemsBase.jl),
  • dcgain,
  • rootlocus,
  • freqresp (SystemsBase.jl),
  • bode (SystemsBase.jl),
  • nyquist (SystemsBase.jl),
  • sigma,
  • plotting through RecipesBase,
  • care,
  • dare,
  • lyap,
  • dlyap,
  • gram,
  • observability,
  • controllability,
  • covar,
  • norm,
  • balance,
  • lqr,
  • dlqr,
  • acker (no need, since place is implemented in robust way),
  • place,
  • rss,
  • drss.

Perhaps of limited use:

  • overshoot,
  • undershoot,
  • finalvalue,
  • peak,
  • peaktime,
  • risetime,
  • settlingtime,
  • isstable,
  • markovparam,
  • damp,
  • dampreport,
  • phasemargin,
  • gainmargin,

Need

To attract users.

References / Links

N/A.

Proposal

N/A.

@CristianRojas
Copy link
Contributor

@aytekinar: It is being discussed whether we should move several of these functions to ControlCore.jl, such as freqresp, bode, nyquist. Regarding the rest, I have implemented/ported some of them for the new types of ControlCore.jl, like dcgain (well, your implementation actually :) ), c2d, d2c, isstable.

Should we move lsim, impulse, step to ControlCore.jl too?

Cc: @neveritt

@aytekinar
Copy link
Author

I just moved those issues from GitLab here. I did not pay attention to those. We can just check the options we have already implemented, either here or in ControlCore :)

@CristianRojas
Copy link
Contributor

Ok :)
By the way, I have separated freqresp, bode and nyquist, and added a few more, in #1 so we can check them individually.

@aytekinar
Copy link
Author

Do we really want to have gangoffour and gangofseven?

@CristianRojas
Copy link
Contributor

CristianRojas commented Nov 5, 2016

Mmm you're right... I have removed them, but instead I have added other functions that we used to have in ControlKTH.

@aytekinar
Copy link
Author

Uhm... I think you wanted to teach me to shut my mouth up! I opposed two functions, and received 8 more, in return :)

CristianRojas added a commit that referenced this issue Nov 12, 2016
WIP: A proposal for `c2d`
aytekinar pushed a commit that referenced this issue May 9, 2017
Fix `c2d` for the new type system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants