From faeb6bca75269afa00765df1ac8f56eefbe23641 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Mon, 21 Jul 2025 14:46:05 +0200 Subject: [PATCH 1/8] switch precommit hooks to Julia --- .pre-commit-hooks.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index 44afe7a..a667d6b 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -1,6 +1,9 @@ +--- - id: explicit-imports name: ExplicitImports checks + description: "ExplicitImports.jl namespace checks" + language: julia entry: ./scripts/explicit-imports.jl --check - files: ^src.*\.jl$ - language: script - pass_filenames: false + types: [julia] + minimum_pre_commit_version: "4.1.0" + additional_dependencies: ["ExplicitImports"] From 0abe086c55d9f4d89ea48fa9d92e498c1e374998 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Mon, 21 Jul 2025 14:53:35 +0200 Subject: [PATCH 2/8] try to remove startup file --- .pre-commit-hooks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index a667d6b..2a43ed1 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -3,7 +3,7 @@ name: ExplicitImports checks description: "ExplicitImports.jl namespace checks" language: julia - entry: ./scripts/explicit-imports.jl --check + entry: --startup-file=no ./scripts/explicit-imports.jl --check types: [julia] minimum_pre_commit_version: "4.1.0" additional_dependencies: ["ExplicitImports"] From f03ab3ef64b516c0c78ab90b4545aef96b8b41c6 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Mon, 21 Jul 2025 15:21:18 +0200 Subject: [PATCH 3/8] rm --- .pre-commit-hooks.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index 2a43ed1..27545e9 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -6,4 +6,3 @@ entry: --startup-file=no ./scripts/explicit-imports.jl --check types: [julia] minimum_pre_commit_version: "4.1.0" - additional_dependencies: ["ExplicitImports"] From e2431aa05cdb7bce680b74cc4d16a7db587366fc Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Mon, 21 Jul 2025 15:21:51 +0200 Subject: [PATCH 4/8] fix --- .pre-commit-hooks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index 27545e9..a36a892 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -3,6 +3,6 @@ name: ExplicitImports checks description: "ExplicitImports.jl namespace checks" language: julia - entry: --startup-file=no ./scripts/explicit-imports.jl --check + entry: ./scripts/explicit-imports.jl --check types: [julia] minimum_pre_commit_version: "4.1.0" From 5687442eeac78c7a54915c1c25d7a4d8fa6416c9 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Mon, 21 Jul 2025 15:30:53 +0200 Subject: [PATCH 5/8] debug --- scripts/explicit-imports.jl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/explicit-imports.jl b/scripts/explicit-imports.jl index 9b1cd2d..bf12003 100755 --- a/scripts/explicit-imports.jl +++ b/scripts/explicit-imports.jl @@ -1,4 +1,6 @@ #!/usr/bin/env julia +@show Base.active_project() +@show ARGS using ExplicitImports: main exit(main(ARGS)) From af9bc6ed12f01076614a9f855f40340fc09f8ab8 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Mon, 21 Jul 2025 15:31:52 +0200 Subject: [PATCH 6/8] fix --- .pre-commit-hooks.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index a36a892..e9ddce1 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -6,3 +6,4 @@ entry: ./scripts/explicit-imports.jl --check types: [julia] minimum_pre_commit_version: "4.1.0" + pass_filenames: false From 188b990f722f3401a14f237325d4c6e3edfb0cf6 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Mon, 21 Jul 2025 15:38:05 +0200 Subject: [PATCH 7/8] bump --- .pre-commit-hooks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index e9ddce1..1852ccd 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -5,5 +5,5 @@ language: julia entry: ./scripts/explicit-imports.jl --check types: [julia] - minimum_pre_commit_version: "4.1.0" + minimum_pre_commit_version: "4.2.0" pass_filenames: false From 1fcbe989a493e9795b5fcdb56a534f30264cf182 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Mon, 21 Jul 2025 15:55:53 +0200 Subject: [PATCH 8/8] rm --- scripts/explicit-imports.jl | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/explicit-imports.jl b/scripts/explicit-imports.jl index bf12003..9b1cd2d 100755 --- a/scripts/explicit-imports.jl +++ b/scripts/explicit-imports.jl @@ -1,6 +1,4 @@ #!/usr/bin/env julia -@show Base.active_project() -@show ARGS using ExplicitImports: main exit(main(ARGS))