Skip to content

Commit fcf068f

Browse files
authored
Use AbstractString in signature instead of String. (#208)
1 parent ba51450 commit fcf068f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Project.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "GitHub"
22
uuid = "bc5e4493-9b4d-5f90-b8aa-2b2bcaad7a26"
3-
version = "5.8.0"
3+
version = "5.8.1"
44

55
[deps]
66
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

src/repositories/commits.jl

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ namefield(commit::Commit) = commit.sha
2828
# repo #
2929
#------#
3030

31-
@api_default function commits(api::GitHubAPI, repo::Union{Repo,String}; options...)
31+
@api_default function commits(api::GitHubAPI, repo::Union{Repo,AbstractString}; options...)
3232
results, page_data = gh_get_paged_json(api, "/repos/$(name(repo))/commits"; options...)
3333
return map(Commit, results), page_data
3434
end
3535

36-
@api_default function commit(api::GitHubAPI, repo, sha::Union{Commit,String}; options...)
36+
@api_default function commit(api::GitHubAPI, repo, sha::Union{Commit,AbstractString}; options...)
3737
result = gh_get_json(api, "/repos/$(name(repo))/commits/$(name(sha))"; options...)
3838
return Commit(result)
3939
end

0 commit comments

Comments
 (0)