test: Move from CDP to BiDi

See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

Adjust the exception handling tests to not wait for RuntimeError, this
is no longer raised.

Author: KKoukiou

Makefile

@@ -114,12 +114,9 @@ install: $(DIST_TEST) po/LINGUAS
 	cp webui-desktop $(DESTDIR)/usr/libexec/
 	ln -sTfr $(DESTDIR)/usr/share/pixmaps/fedora-logo-sprite.svg $(DESTDIR)/usr/share/cockpit/$(PACKAGE_NAME)/logo.svg
 
-# required for running integration tests; commander and ws are deps of chrome-remote-interface
+# required for running integration tests;
 TEST_NPMS = \
-	node_modules/chrome-remote-interface \
-	node_modules/commander \
 	node_modules/sizzle \
-	node_modules/ws \
 	$(NULL)
 
 dist: $(TARFILE)
@@ -155,7 +152,7 @@ COCKPIT_REPO_FILES = \
 	$(NULL)
 
 COCKPIT_REPO_URL = https://github.com/cockpit-project/cockpit.git
-COCKPIT_REPO_COMMIT = 07fddba43934fb256ec8da03812f081eab3baa18 # 321 + 117 commits
+COCKPIT_REPO_COMMIT = 8ede522e5066e680850dd2ae049e2e24f99c4230 # 322 + 30 commits
 
 $(COCKPIT_REPO_FILES): $(COCKPIT_REPO_STAMP)
 COCKPIT_REPO_TREE = '$(strip $(COCKPIT_REPO_COMMIT))^{tree}'

package.json

@@ -14,7 +14,6 @@
     "stylelint:fix": "stylelint --fix 'src/**/*{.css,scss}'"
   },
   "devDependencies": {
-    "chrome-remote-interface": "0.33.2",
     "esbuild": "0.23.0",
     "esbuild-plugin-copy": "2.1.1",
     "esbuild-plugin-replace": "1.4.0",
@@ -32,6 +31,7 @@
     "eslint-plugin-simple-import-sort": "^12.0.0",
     "eslint-plugin-sort-destructure-keys": "^2.0.0",
     "gettext-parser": "8.0.0",
+    "glob": "11.0.0",
     "htmlparser": "1.7.7",
     "jed": "1.1.1",
     "qunit": "2.21.1",

test/check-basic

@@ -15,8 +15,6 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this program; If not, see <http://www.gnu.org/licenses/>.
 
-import time
-
 from anacondalib import VirtInstallMachineCase
 from installer import Installer
 from language import Language
@@ -249,12 +247,8 @@ class TestBasic(VirtInstallMachineCase):
 
         b.wait_not_present("#critical-error-bz-report-modal.pf-v5-c-modal-box")
 
-        with self.assertRaises(RuntimeError):
-            b.eval_js("window.setTimeout(function() { myNonExistingFunction()}, 0);")
-            # Some round trips, one of which should update the deferred exception
-            for _ in range(0, 5):
-                b.wait_in_text("#critical-error-bz-report-modal-details", "myNonExistingFunction is not defined")
-                time.sleep(2)
+        b.eval_js("window.setTimeout(function() { myNonExistingFunction()}, 0);")
+        b.wait_in_text("#critical-error-bz-report-modal-details", "myNonExistingFunction is not defined")
 
         b.wait_visible("a:contains('Report issue'):not([disabled])")
         b.assert_pixels(

test/check-storage-basic

@@ -196,10 +196,9 @@ class TestStorage(VirtInstallMachineCase, StorageHelpers):
 
         b.wait_not_present("#critical-error-bz-report-modal.pf-v5-c-modal-box")
 
-        with self.assertRaises(RuntimeError):
-            b.eval_js("window.setTimeout(function() {throw new Error('Unexpected storage JS error')}, 0);")
-            b.wait_in_text("#critical-error-bz-report-modal-details", "Unexpected storage JS error")
-            b.wait_in_text("#critical-error-bz-report-modal header", "The installer cannot continue due to a critical error: Storage plugin failed")
+        b.eval_js("window.setTimeout(function() {throw new Error('Unexpected storage JS error')}, 0);")
+        b.wait_in_text("#critical-error-bz-report-modal-details", "Unexpected storage JS error")
+        b.wait_in_text("#critical-error-bz-report-modal header", "The installer cannot continue due to a critical error: Storage plugin failed")
 
 @nondestructive
 class TestMultipleDisks(VirtInstallMachineCase, StorageHelpers):