Merge pull request #636 from RichardLake/Issue605

CmdLine: Run scan before install/update, better msg on autoinstalled mods.
KSP-CKAN · Dec 19, 2014 · 2132b46 · 2132b46
2 parents 4db2123 + 64a9add
commit 2132b46
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/CKAN/CmdLine/Action/Upgrade.cs b/CKAN/CmdLine/Action/Upgrade.cs
@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Linq;
 using System.Text.RegularExpressions;
 
 namespace CKAN.CmdLine
@@ -60,6 +61,14 @@ public int RunCommand(CKAN.KSP ksp, object raw_options)
             }
 
 
+            var auto_detected_modules = to_upgrade.Where(module => ksp.Registry.IsAutodetected(module.identifier)).ToList();
+            foreach (var module in auto_detected_modules.Select(mod => mod.identifier))
+            {
+                User.RaiseMessage("Cannot upgrade {0} as it was not installed by CKAN. \n Please remove manually before trying again", module);
+            }
+            //Exit if any are auto_detected
+            if (auto_detected_modules.Any()) return Exit.ERROR;   
+
             User.RaiseMessage("\nUpgrading modules...\n");
             // TODO: These instances all need to go.
             ModuleInstaller.GetInstance(ksp, User).Upgrade(to_upgrade,new NetAsyncDownloader(User));

diff --git a/CKAN/CmdLine/Main.cs b/CKAN/CmdLine/Main.cs
@@ -155,6 +155,7 @@ public static int Main(string[] args)
                     return Available(manager.CurrentInstance, user);
 
                 case "install":
+                    Scan(manager.CurrentInstance);
                     return Install((InstallOptions)cmdline.options, manager.CurrentInstance, user);
 
                 case "scan":
@@ -170,6 +171,7 @@ public static int Main(string[] args)
                     return Remove((RemoveOptions)cmdline.options, manager.CurrentInstance, user);
 
                 case "upgrade":
+                    Scan(manager.CurrentInstance);
                     var upgrade = new Upgrade(user);
                     return upgrade.RunCommand(manager.CurrentInstance, cmdline.options);
 

diff --git a/CKAN/GUI/Util.cs b/CKAN/GUI/Util.cs
@@ -1,13 +1,14 @@
 using System;
-using System.Runtime.InteropServices;
-using System.Windows.Forms;
+
 
 namespace CKAN
 {
+    using System.Runtime.InteropServices;
+    using System.Windows.Forms;
 
     public static class Util
     {
-
+        
         public static bool IsLinux
         {
             get
@@ -75,12 +76,17 @@ public static void HideConsoleWindow()
                 ShowWindow(GetConsoleWindow(), 0);
             }
         }
+   }
+}
 
-
+namespace CKAN
+{
+    public static class UtilWithoutWinForm
+    {
         public static bool IsInstallable(this GUIMod mod)
         {
+
             return !(mod == null || mod.IsAutodetected || mod.IsIncompatible);
         }
-   }
-
+    }
 }