Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix searching for Steam in .NET 8 by correcting path on macOS #4322

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix searching for Steam in .NET 8 by correcting path on macOS #4322

merged 2 commits into from
Feb 24, 2025

Conversation

doinkythederp
Copy link
Contributor

@doinkythederp doinkythederp commented Feb 24, 2025 •
edited by HebaruSan
Loading

@doinkythederp
Copy link
Contributor Author 

40929 [1] FATAL CKAN.NetKAN.Program (null) - The operation has timed out.

Test failure seems unrelated

@doinkythederp doinkythederp changed the title fix(.NET 8): search for steam in correct path Fix searching for Steam in .NET 8 by correcting path on macOS Feb 24, 2025
HebaruSan
HebaruSan approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🏍️

@HebaruSan HebaruSan added Core (ckan.dll) Issues affecting the core part of CKAN macOS Issues specific for macOS labels Feb 24, 2025
@HebaruSan HebaruSan merged commit 8036473 into KSP-CKAN:master Feb 24, 2025
2 checks passed
@doinkythederp doinkythederp deleted the fix/dotnet8-steam-detection branch February 25, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HebaruSan HebaruSan HebaruSan approved these changes

Assignees
No one assigned
Labels
Core (ckan.dll) Issues affecting the core part of CKAN macOS Issues specific for macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: CKAN-Core on .NET 8+ on macOS can't find Steam
2 participants
@doinkythederp @HebaruSan