Fix admin user deletion on profile #495
Merged
+22
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As of #316, the user profile page now has a "Delete user" button for admins, which opens a confirmation dialog:
However, no matter what you do, the "Delete account" button in the confirmation popup doesn't work. The call to the server never happens.
Cause
Since the profile editing page has a rich text box, and the
profile.coffee
/profile.js
client file is shared between the profile editing page and the profile viewing page, the rich text editor tries to initialize on page load and throws an exception because there are notextarea
s, just like in 1e130af.This exception then stops the client code initialization, so the hooks that make the popup work are not set up.
Changes
textarea
for it to use. This will allow the initialization to complete and the "Delete account" button will work./api/user/<username>/delete
now returns 200 on success instead of 400