-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rojo - Add support for indexing non-script instances #37
Comments
Rojo exposes an HTTP interface that you could probably use for this. |
Didn't mean to close, oops. |
Interesting. What would be the best way to use this HTTP interface? You can't just assume that (1) rojo is running and (2) its running on the default port. If rojo wasn't running, would we keep making a request to see if its now running? I believe the best option would be for the user to explicitly say to connect to the Rojo HTTP interface (via a command probably), and also explicitly provide the port (whilst also providing the default port as standard). This would probably be the simplest way to do so, but a user may forget to run this command when they begin developing (Maybe add an indicator in the status bar whether we are listening?) Also, we should weigh the pros and cons of using this HTTP interface - would just reading the relevant files suffice? Depends what is the easiest to implement. |
[Commenting what was said in the Discord Server] It is important that whilst using the HTTP interface, the current system of reading the project files manually should remain. The HTTP interface should act more as an "assist". There is also the issue that the Rojo server must be online for this to work, whereas reading project files is in-house and isn't dependent on that. Also, this issue needs to take into account multi-place workspaces. How will the extension determine which tree is correct for this workspace? We don't really want to have to connect to each individual Rojo server either |
Add support for items like Parts etc.
Eg: If there was a part in ReplicatedStorage, it would autofill
ReplicatedStorage.Part
An addition to this would be to also support the members of the Instance type in autocomplete, so it could autofill
ReplicatedStorage.Part.Anchored
for example - Could read the.model.json
or.meta.json
to find the classNameThe text was updated successfully, but these errors were encountered: