Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Instance.new autocomplete not prompt on dot (.) #6

Open
murtlatif opened this issue Jun 4, 2019 · 4 comments · May be fixed by #28
Open

Make Instance.new autocomplete not prompt on dot (.) #6

murtlatif opened this issue Jun 4, 2019 · 4 comments · May be fixed by #28
Labels
enhancement New feature or request good first issue Good for newcomers scope: ts

Comments

@murtlatif
Copy link

Anytime a period is used, the Instance.new autocomplete prompt appears, which is annoying especially when typing out sentences ending in periods.
For example:
image

@Kampfkarren Kampfkarren added the enhancement New feature or request label Jun 4, 2019
@Kampfkarren Kampfkarren changed the title Instance.new autocomplete prompt on dot (.) Make Instance.new autocomplete not prompt on dot (.) Jun 4, 2019
@Kampfkarren
Copy link
Owner

An easy fix could be just to change the thing you need to type to Instance, that's what most people are doing right now anyway.

@Kampfkarren
Copy link
Owner

Actually, since we know what the text is like before returning Instance.new, it could check if the last character is a dot, and just not send if the word preceding isn't Instance.

@Kampfkarren Kampfkarren added the good first issue Good for newcomers label Sep 6, 2019
@JohnnyMorganz
Copy link
Contributor

With #28, Instance.new is provided by the Autocomplete Metadata, so the Instance.new built-in autocomplete suggestion can be removed.
However, the autocomplete does not provide autofill for the Instance type within the brackets, so that will need to be implemented

@Kampfkarren
Copy link
Owner

However, the autocomplete does not provide autofill for the Instance type within the brackets, so that will need to be implemented

This is a pretty important feature to me, so definitely would not want to lose that.

@JohnnyMorganz JohnnyMorganz linked a pull request Jun 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers scope: ts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants