Unflub clang-tidy (CleverRaven#57450)

Author: akrieger

Makefile

@@ -944,7 +944,7 @@ $(ODIR)/%.inc: $(SRC_DIR)/%.cpp
 
 .PHONY: includes
 includes: $(OBJS:.o=.inc)
-	make -C tests includes
+	+make -C tests includes
 
 $(ODIR)/%.o: $(SRC_DIR)/%.cpp $(PCH_P)
 	$(CXX) $(CPPFLAGS) $(DEFINES) $(CXXFLAGS) -MMD -MP $(PCHFLAGS) -c $< -o $@

build-scripts/build.sh

@@ -158,12 +158,13 @@ then
             tidyable_cpp_files=$all_cpp_files
         else
             make \
+                -j $num_jobs \
                 ${COMPILER:+COMPILER=$COMPILER} \
                 TILES=${TILES:-0} \
                 SOUND=${SOUND:-0} \
                 includes
 
-            ./files_changed < ./build-scripts/files_changed
+            ./build-scripts/files_changed > ./files_changed
             tidyable_cpp_files="$( \
                 ( build-scripts/get_affected_files.py ./files_changed ) || \
                 echo unknown )"

build-scripts/clang-tidy.sh

@@ -102,6 +102,7 @@ then
     tidyable_cpp_files=$all_cpp_files
 else
     make \
+        -j $num_jobs \
         ${COMPILER:+COMPILER=$COMPILER} \
         TILES=${TILES:-0} \
         SOUND=${SOUND:-0} \

build-scripts/files_changed

@@ -43,6 +43,9 @@ then
         fi
     done
     files_list "$( git merge-base "$base" HEAD^2 )..HEAD^2"
+elif [ -n "$GIT_LOCAL_BASE_REF" ]
+then
+    files_list "$GIT_LOCAL_BASE_REF..HEAD"
 else
     echo 'Neither $TRAVIS nor $GITHUB_BASE_REF was defined' >&2
     exit 1

build-scripts/get_affected_files.py

@@ -37,6 +37,12 @@ def parse_includes_file(
                 set(),
             ).add(source_file_path)
 
+        # A source file also 'includes' itself
+        self.includes_to_sources.setdefault(
+            source_file_path,
+            set(),
+        ).add(source_file_path)
+
     # Parses includes files from a given folder
     # Maps include file path to a source file path by converting
     # folder_path/*.inc -> file_path_prefix/*.cpp