Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Check Grammer #35

Open
KendallDoesCoding opened this issue Mar 12, 2023 · 10 comments
Open

Double Check Grammer #35

KendallDoesCoding opened this issue Mar 12, 2023 · 10 comments
Assignees
Labels
EddieHub:good-first-issue enhancement New feature or request good first issue Good for newcomers

Comments

@KendallDoesCoding
Copy link
Owner

I've been finding a few spelling mistakes lately, for example a missing "to" (2c8bc5e), etc. I need someone to double check the grammar for all the chapters (throughout the game) and ensure that there are no spelling mistakes.

@Akbar-Ahmed
Copy link
Contributor

I would like to work on this.

@KendallDoesCoding
Copy link
Owner Author

I would like to work on this.

Assigned you!

Checkout the chapters.py and main.py file!

Saksham093 added a commit to Saksham093/Choose-Your-Own-Adventure-Game that referenced this issue Mar 13, 2023
There where many spell mistakes and grammar too - all fixed and also added a mountain chapter.
KendallDoesCoding#35 fixed :
@KendallDoesCoding KendallDoesCoding linked a pull request Mar 13, 2023 that will close this issue
3 tasks
@KendallDoesCoding
Copy link
Owner Author

@Akbar-Ahmed - even though you are assigned. @Saksham093 made a PR, should I go ahead with theirs?

@Saksham093, please request to be assigned next time before working on a PR.

@Saksham093
Copy link
Contributor

Okay .... I'm sorry for this. I will take care of this.

@KendallDoesCoding
Copy link
Owner Author

Okay .... I'm sorry for this. I will take care of this.

No worries. I'll let you go this time but just keep it in mind. I used to make the same mistakes but then I was adviced to ask to be assigned!

@Akbar-Ahmed
Copy link
Contributor

Hello @KendallDoesCoding , @Saksham093 we are all here to collaborate and learn. @KendallDoesCoding yes you can go ahead with PR by @Saksham093 . I am also raising a PR. I have checked chapters.py file and made some changes into that, However the main.py file looks good. So no change is required.

@KendallDoesCoding
Copy link
Owner Author

KendallDoesCoding commented Mar 14, 2023 via email

@KendallDoesCoding
Copy link
Owner Author

Are we ready to close this?

@devyanshiiii21
Copy link

@KendallDoesCoding I'd like to work on this issue. Can you assign it to me?

@KendallDoesCoding
Copy link
Owner Author

@KendallDoesCoding I'd like to work on this issue. Can you assign it to me?

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EddieHub:good-first-issue enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants