Remove const local variables as they're deprecated

Author: staticfloat

src/COFF/COFFHandle.jl

@@ -29,8 +29,8 @@ end
 ## Define creation methods
 function readmeta(io::IO, ::Type{H}) where {H <: COFFHandle}
     # This is the magic that we know we must find
-    const PE_magic = UInt8['P','E','\0','\0']
-    const MZ_magic = UInt8['M','Z']
+    PE_magic = UInt8['P','E','\0','\0']
+    MZ_magic = UInt8['M','Z']
 
     # Save the starting position of `io`
     start = position(io)

src/COFF/COFFHeader.jl

@@ -11,7 +11,7 @@ export COFFHeader
 end
 
 function coff_header_is64bit(h::COFFHeader)
-    const wide_machines = [
+    wide_machines = [
         IMAGE_FILE_MACHINE_AMD64,
         IMAGE_FILE_MACHINE_ARM64,
         IMAGE_FILE_MACHINE_IA64,

src/ELF/ELFDynEntry.jl

@@ -44,7 +44,7 @@ Return `true` if the given `ELFDynEntry` represents an offset within the
 dynamic string table, and therefore can be used in a `strtab_lookup()`
 """
 function dyn_entry_is_string(d::ELFDynEntry)
-    const string_types = [
+    string_types = [
         DT_NEEDED,
         DT_SONAME,
         DT_RPATH,

src/ELF/ELFHandle.jl

@@ -32,7 +32,7 @@ end
 ## Define creation methods
 function readmeta(io::IO, ::Type{H}) where {H <: ELFHandle}
     # This is the magic that we know we must find
-    const elven_magic = UInt8['\177', 'E', 'L', 'F']
+    elven_magic = UInt8['\177', 'E', 'L', 'F']
 
     # Save the starting position of `io`
     start = position(io)

src/MachO/MachOLoadCmd.jl

@@ -183,7 +183,7 @@ find(lcs::MachOLoadCmds, lc_type::T) where {T <: Type} = find(lcs, [lc_type])
 
 
 function load_cmd_type(header::MachOLoadCmdHeader{H}) where {H <: MachOHandle}
-    const type_mapping = Dict(
+    type_mapping = Dict(
         LC_SEGMENT => MachOSegment32Cmd{H},
         LC_SEGMENT_64 => MachOSegment64Cmd{H},
         LC_LOAD_DYLIB => MachOLoadDylibCmd{H},
@@ -231,7 +231,7 @@ and ending no more than `max_size` bytes ahead, read it in and return it as a
 Julia-native `String`.  If the given offset is bad in some way (it is negative,
 or begins beyond the end of `max_size`) an error string is returned.
 """
-function unpack_lcstr{H<:ObjectHandle}(oh::H, offset, max_size)
+function unpack_lcstr(oh::H, offset, max_size) where {H <: MachOHandle}
     # Perform sanity checking on offset; if it is too small or too large,
     # don't try to read the lc_str, just assign it "<lc_str offset corrupt>"
     if offset >= 0 && offset < max_size

src/string_utils.jl

@@ -39,7 +39,7 @@ print(io::IO, x::fixed_string) = print(io, unsafe_string(x))
 isempty(x::fixed_string) = (x.data & 0xff) == 0
 function length(x::fixed_string{T}) where {T <: Integer}
     for idx in 0:(sizeof(T)-1)
-        if (x.data & (0xff << idx*8)) == 0
+        if (x.data & (0xff << (idx*8))) == 0
             return idx
         end
     end

test/runtests.jl

@@ -8,7 +8,7 @@ function test_libfoo_and_fooifier(fooifier_path, libfoo_path)
 
     # Tease out some information from the containing folder name
     dir_path = basename(dirname(libfoo_path))
-    const types = Dict(
+    types = Dict(
         "linux" => ELFHandle,
         "mac" => MachOHandle,
         "win" => COFFHandle,