msglist: Use faster fade to hidden animation for mark as read button

Fixes: zulip#613

Author: Khader-1

lib/widgets/message_list.dart

@@ -507,10 +507,9 @@ class MarkAsReadWidgetState extends State<MarkAsReadWidget> {
 
     return IgnorePointer(
       ignoring: areMessagesRead,
-      child: AnimatedOpacity(
-        opacity: areMessagesRead ? 0 : loading ? 0.5 : 1,
-        duration: Duration(milliseconds: areMessagesRead ? 2000 : 300),
-        curve: Curves.easeOut,
+      child: MarkAsReadAnimation(
+        loading: loading,
+        hidden: areMessagesRead,
         child: SizedBox(width: double.infinity,
           // Design referenced from:
           //   https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?type=design&node-id=132-9684&mode=design&t=jJwHzloKJ0TMOG4M-0
@@ -544,6 +543,28 @@ class MarkAsReadWidgetState extends State<MarkAsReadWidget> {
   }
 }
 
+class MarkAsReadAnimation extends StatelessWidget {
+  final bool loading;
+  final bool hidden;
+  final Widget child;
+
+  const MarkAsReadAnimation({
+    super.key,
+    required this.loading,
+    required this.hidden,
+    required this.child
+  });
+
+  @override
+  Widget build(BuildContext context) {
+    return AnimatedOpacity(
+      opacity: hidden ? 0 : loading ? 0.5 : 1,
+      duration: const Duration(milliseconds: 500),
+      curve: Curves.easeOut,
+      child: child);
+  }
+}
+
 class RecipientHeader extends StatelessWidget {
   const RecipientHeader({super.key, required this.message, required this.narrow});
 

test/widgets/message_list_test.dart

@@ -948,6 +948,46 @@ void main() {
 
           check(state.loading).isFalse();
         });
+
+        testWidgets('in idle state', (WidgetTester tester) async {
+          final child = Container();
+
+          await tester.pumpWidget(MaterialApp(
+            home: MarkAsReadAnimation(hidden: false, loading: false, child: child)));
+
+          check(find.byWidget(child).evaluate()).length.equals(1);
+          check(tester.widget<AnimatedOpacity>(find.byType(AnimatedOpacity)).opacity).equals(1);
+        });
+
+        testWidgets('in loading state', (WidgetTester tester) async {
+          final child = Container();
+
+          await tester.pumpWidget(MaterialApp(
+            home: MarkAsReadAnimation(hidden: false, loading: true, child: child)));
+
+          check(find.byWidget(child).evaluate()).length.equals(1);
+          check(tester.widget<AnimatedOpacity>(find.byType(AnimatedOpacity)).opacity).equals(0.5);
+        });
+
+        testWidgets('in hidden state', (WidgetTester tester) async {
+          final child = Container();
+
+          await tester.pumpWidget(MaterialApp(
+            home: MarkAsReadAnimation(hidden: true, loading: false, child: child)));
+
+          check(find.byWidget(child).evaluate()).length.equals(1);
+          check(tester.widget<AnimatedOpacity>(find.byType(AnimatedOpacity)).opacity).equals(0);
+        });
+
+        testWidgets('in hidden state but loading is true', (WidgetTester tester) async {
+          final child = Container();
+
+          await tester.pumpWidget(MaterialApp(
+            home: MarkAsReadAnimation(hidden: true, loading: true, child: child)));
+
+          check(find.byWidget(child).evaluate()).length.equals(1);
+          check(tester.widget<AnimatedOpacity>(find.byType(AnimatedOpacity)).opacity).equals(0);
+        });
       });
 
       testWidgets('smoke test on modern server', (WidgetTester tester) async {