Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler issues in Unity 2020.3.25f1 #642

Closed
2-3-5-41 opened this issue Feb 20, 2022 · 9 comments · Fixed by #644
Closed

Compiler issues in Unity 2020.3.25f1 #642

2-3-5-41 opened this issue Feb 20, 2022 · 9 comments · Fixed by #644

Comments

@2-3-5-41
Copy link

Errors from unity package.

When importing the unitypackage provided in the builds into Unity 2020.3.25f1 LTS, there are compiler errors complaining about multiple precompiled assemblies in the project, these are coming from the two Newtonsoft.json assemblies, one provided in the package, and one provided by unity by default in the package manager.

image

Post removal of extra Newtonsoft.json.dll

image


Errors from repo project file.

I've also downloaded the repo and tried opening the "UnityGLTF" project file with Unity 2020.3.25f1 LTS, and was prompted to load in safe mode, upon doing so, I'm presented with numerous compiler errors pertaining to cache, and extensions scripts. Up to 150 unique compiler errors.

image

@JuniorBaltazar
Copy link

Same problems in Unity 2020.3.27f1 (LTS)

@FlintNT
Copy link

FlintNT commented Mar 11, 2022

Same problems in 2020.3.30f1

@rycsim
Copy link

rycsim commented Mar 24, 2022

me too

@hybridherbst
Copy link
Collaborator

hybridherbst commented Apr 8, 2022

Hi, this should be fixed on the dev branch and in this PR:

Would be great if you test that out, easy Unity package instructions are included in the link above.

@hybridherbst hybridherbst linked a pull request Apr 8, 2022 that will close this issue
@Sparks-Lu
Copy link

Uploading 1650442065(1).png…

The fix has been tested. During import, there're three errors. Below are details.

  1. Library\PackageCache\org.khronos.unitygltf@55b8a8b\Editor\Scripts\GLTFImporter.cs(169,68): error CS0104: 'Animation' is an ambiguous reference between 'GLTF.Schema.Animation' and 'UnityEngine.Animation'

  2. Library\PackageCache\org.khronos.unitygltf@55b8a8b\Editor\Scripts\GLTFImporter.cs(340,16): error CS1501: No overload for method 'ParseJson' takes 2 arguments

  3. Plugin 'Assets/Sketchfab For Unity/Dependencies/Libraries/GLTFSerialization.dll' has the same filename as Assembly Definition File 'Packages/org.khronos.unitygltf/Runtime/Plugins/GLTFSerialization/GLTFSerialization.asmdef'. Rename the assemblies to avoid hard to diagnose issues and crashes.

Would you please have a look? Thanks in advance.

@hybridherbst
Copy link
Collaborator

@Sparks-Lu Thanks, could you let me know which Unity version you're on?

Also, it looks like you have both "Sketchfab for Unity" and "UnityGltf" in the same project. Since the former was built on top of the latter, I don't think this is a usecase that can be reasonably supported, or rather that needs some fixes in "Sketchfab for Unity" - can look at that once the PR is merged.

@Sparks-Lu
Copy link

Sparks-Lu commented Apr 20, 2022

@Sparks-Lu Thanks, could you let me know which Unity version you're on?

My Unity version is 2020.3.25f1c1.

Also, it looks like you have both "Sketchfab for Unity" and "UnityGltf" in the same project. Since the former was built on top of the latter, I don't think this is a usecase that can be reasonably supported, or rather that needs some fixes in "Sketchfab for Unity" - can look at that once the PR is merged.

I see. Thanks.

@dayowoo
Copy link

dayowoo commented Nov 3, 2022

Hi, this should be fixed on the dev branch and in this PR:

Would be great if you test that out, easy Unity package instructions are included in the link above.

I installed this package, but the error is still.
How do I solve it?
My Unity version is 2021.3.9f1.

@hybridherbst
Copy link
Collaborator

hybridherbst commented Nov 3, 2022

@dayowoo you installed which package? Did you use the git package as instructed on the readme from the prefrontal cortex fork, or the currently outdated .unitypackage from this repo here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants