File tree Expand file tree Collapse file tree 1 file changed +10
-0
lines changed Expand file tree Collapse file tree 1 file changed +10
-0
lines changed Original file line number Diff line number Diff line change @@ -127,6 +127,16 @@ cmake ... -D UPDATE_DEPS=ON -D BUILD_TESTS=ON ...
127
127
```
128
128
This will ensure googletest and detours is downloaded and the appropriate version is used.
129
129
130
+ ### Warnings as errors off by default!
131
+
132
+ By default ` BUILD_WERROR ` is ` OFF ` . The idiom for open source projects is to NOT enable warnings as errors.
133
+
134
+ System/language package managers have to build on multiple different platforms and compilers.
135
+
136
+ By defaulting to ` ON ` we cause issues for package managers since there is no standard way to disable warnings.
137
+
138
+ Add ` -D BUILD_WERROR=ON ` to your workflow
139
+
130
140
### Build and Install Directory Locations
131
141
132
142
A common convention is to place the ` build ` directory in the top directory of
You can’t perform that action at this time.
0 commit comments