Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong struct in MultiDrawIndirect documentation example #1266

Open
DeltaW0x opened this issue Jan 31, 2025 · 1 comment · May be fixed by #1271
Open

Wrong struct in MultiDrawIndirect documentation example #1266

DeltaW0x opened this issue Jan 31, 2025 · 1 comment · May be fixed by #1271
Assignees
@SaschaWillems
Labels
documentation Improvements or additions to documentation

Comments

@DeltaW0x
Copy link

DeltaW0x commented Jan 31, 2025 •
edited
Loading

In the Draw Call Generation paragraph inside GPU Rendering and Multi-Draw Indirect,
VkPhysicalDeviceFeatures2::bufferDeviceAddress is mistakenly used to check for multi draw indirect support instead of VkPhysicalDeviceFeatures::multiDrawIndirect, unless there's another reason I'm missing

If = device supports multi-draw indirect (VkPhysicalDeviceFeatures2::bufferDeviceAddress), then the entire array of draw commands can be executed through a single call to VkDrawIndexedIndirectCommand.
@oddhack
Copy link
Contributor

oddhack commented Jan 31, 2025

Moving to Vulkan-Samples where that documentation is maintained.

@oddhack oddhack transferred this issue from KhronosGroup/Vulkan-Docs Jan 31, 2025
@SaschaWillems SaschaWillems self-assigned this Feb 4, 2025
SaschaWillems added a commit to SaschaWillems/Vulkan-Samples that referenced this issue Feb 4, 2025
@SaschaWillems
Use correct device feature
6958165 
Fixes KhronosGroup#1266
@SaschaWillems SaschaWillems linked a pull request Feb 4, 2025 that will close this issue
Open
13 tasks
@SaschaWillems SaschaWillems added the documentation Improvements or additions to documentation label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaschaWillems SaschaWillems

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct device feature in multi draw indirect sample documentation SaschaWillems/Vulkan-Samples
3 participants
@oddhack @SaschaWillems @DeltaW0x