-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make vulkaninfo removal of promoted extension structures optional #963
Comments
In the Vulkan Profiles merge script, the argument is called (It's not promoted extensions, but the structures, even promoted structures, that are removed) |
|
Jumping on this to add that we were recently bitten by this. We use vulkaninfo's json option for checking implementation features/properties to avoid running unsupported tests/content. |
@rumblehhh I pushed up a new option to vulkaninfo |
@charles-lunarg thanks for the changes! I've checked out the branch and I believe this should work fine for us. Taking the
As for other names: |
@charles-lunarg are there any updates on this? |
@rumblehhh I took your advice and changed it to `--show-promoted-structs. "all" implies things that are above and beyond what are actually being done. @JamesRumble-IMG Thank you for the reminder - this PR was low priority and thus fell off my todo list. It was a simple rebase and name change to get this ready to ship. (I also found a bug in my code, so that was good). |
Thanks very much for adding the |
PR #948 removed extension structures from vulkaninfo output that were promoted to core Vulkan, eg into the VkPhysicalDeviceVulkan(11|12|13)(Features|Properties) structs. It was done for Vulkan profile generation, but it users who are looking for the extension structures explicitly as they no longer appear.
PR 948 was a necessary contribution to allow correct Vulkan-Profile output, but should be a command line option, eg
--remove-promoted-extensions
--strip_duplicate_struct
.The text was updated successfully, but these errors were encountered: