Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified glfw3 example to use docking #4

Open
wants to merge 14 commits into
base: upgrade/v1.79
Choose a base branch
from

Conversation

blenderaxom
Copy link

No description provided.

@blenderaxom blenderaxom closed this Aug 2, 2021
@KinoxKlark
Copy link
Owner

Thanks for your help! I am still on vacation and can't look at this until next week. Any reason why you closed the push request that soon?

@blenderaxom
Copy link
Author

blenderaxom commented Aug 3, 2021 via email

@blenderaxom blenderaxom reopened this Aug 3, 2021
@blenderaxom
Copy link
Author

I've added many new apis of the docking branch in this pull request. The GLFW example is working fine with the docking api.
The docking branch tag should be exactly this one https://github.com/ocornut/imgui/tree/71a78dd2acb5e8a82220f03ba1b382175b5c7913

@KinoxKlark
Copy link
Owner

Sounds awesome, I'll check it when I can thanks. Docking features have been wanted for a long time and we are thinking about how to deal with it in terms of branch and/or pypi package. Feel free to drop your opinion on that matter here: pyimgui#237.

I will soon merge my branch to the official pyimgui. I am not sure how this will work with forks from my fork, but I'm sure we will figure something out. You will probably need to rebase your push request to a branch of the official pyimgui. But for now, continue like that, I'll tell you if you need to do anything.

@blenderaxom
Copy link
Author

Ok thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants