Tests: Use input type=email as selector, as this is now the default for GF 2.8+

Author: n7studios

tests/acceptance/forms/FormCest.php

@@ -62,7 +62,7 @@ public function testCreateFormAndFeed(AcceptanceTester $I)
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 
 		// Submit Form.
 		$I->click('Submit');
@@ -135,7 +135,7 @@ public function testCreateFormAndFeedWithNoConvertKitFormSelected(AcceptanceTest
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 
 		// Submit Form.
 		$I->click('Submit');
@@ -320,7 +320,7 @@ public function testCreateFormAndFeedWithTagAndFieldTagSelected(AcceptanceTester
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 		$I->selectOption('select.gfield_select', $_ENV['CONVERTKIT_API_ADDITIONAL_TAG_NAME']);
 
 		// Submit Form.
@@ -399,7 +399,7 @@ public function testCreateFormAndFeedWithFieldTagSelected(AcceptanceTester $I)
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 		$I->selectOption('select.gfield_select', $_ENV['CONVERTKIT_API_ADDITIONAL_TAG_NAME']);
 
 		// Submit Form.
@@ -478,7 +478,7 @@ public function testCreateFormAndFeedWithInvalidFieldTagSelected(AcceptanceTeste
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 		$I->selectOption( 'select.gfield_select', 'fakeTagNotInConvertKit' );
 
 		// Submit Form.
@@ -557,7 +557,7 @@ public function testCreateFormAndFeedWithTagSelected(AcceptanceTester $I)
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 
 		// Submit Form.
 		$I->click('Submit');
@@ -641,7 +641,7 @@ public function testCreateFormAndFeedWithConditionalLogicMatching(AcceptanceTest
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 
 		// Submit Form.
 		$I->click('Submit');
@@ -720,7 +720,7 @@ public function testCreateFormAndFeedWithConditionalLogicDoesNotMatch(Acceptance
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 
 		// Submit Form.
 		$I->click('Submit');
@@ -790,7 +790,7 @@ public function testCreateFormAndFeedDisabled(AcceptanceTester $I)
 		// Complete Form Fields.
 		$I->fillField('.name_first input[type=text]', $firstName);
 		$I->fillField('.name_last input[type=text]', $lastName);
-		$I->fillField('.ginput_container_email input[type=text]', $emailAddress);
+		$I->fillField('.ginput_container_email input[type=email]', $emailAddress);
 
 		// Submit Form.
 		$I->click('Submit');

tests/acceptance/general/NoticesCest.php

@@ -69,6 +69,7 @@ public function testPersistentNoticeNotDisplayedWhenOfficialAddonActive(Acceptan
 		// Confirm no notice from this Plugin displays.
 		$I->dontSee($this->expectedNoticeText);
 
+		// When the official add-on is activated, it checks whether this Plugin is also active, deactivating it if so.
 		// Confirm the official add-on displays its notice that it deactivated this Plugin.
 		$I->see('In order to prevent conflicts, we disabled the existing ConvertKit for Gravity Forms plugin.');
 	}