Merge pull request #77 from ConvertKit/remove-rocket-loader

Remove `rocket-loader.min.js` from Landing Pages

Author: n7studios

src/class-convertkit-api-traits.php

@@ -1662,6 +1662,12 @@ public function convert_relative_to_absolute_urls(\DOMNodeList $elements, string
                 continue;
             }
 
+            // Remove element if it's rocket-loader.min.js. Including it prevents landing page redirects from working.
+            if (strpos($element->getAttribute($attribute), 'rocket-loader.min.js') !== false) {
+                $element->parentNode->removeChild($element);
+                continue;
+            }
+
             // If here, the attribute's value is a relative URL, missing the http(s) and domain.
             // Prepend the URL to the attribute's value.
             $element->setAttribute($attribute, $url . $element->getAttribute($attribute));

tests/wpunit/APITest.php

@@ -6155,6 +6155,9 @@ public function testGetLandingPageHTML()
 		$result = $this->api->get_landing_page_html($_ENV['CONVERTKIT_API_LANDING_PAGE_URL']);
 		$this->assertNotInstanceOf(WP_Error::class, $result);
 		$this->assertStringContainsString('<form method="POST" action="https://app.convertkit.com/forms/' . $_ENV['CONVERTKIT_API_LANDING_PAGE_ID'] . '/subscriptions" data-sv-form="' . $_ENV['CONVERTKIT_API_LANDING_PAGE_ID'] . '" data-uid="99f1db6843" class="formkit-form"', $result);
+
+		// Check that rocket-loader.min.js has been removed, as including it breaks landing page redirects.
+		$this->assertStringNotContainsString('rocket-loader.min.js', $result);
 	}
 
 	/**
@@ -6171,6 +6174,9 @@ public function testGetLandingPageWithCharacterEncodingHTML()
 
 		// Assert that character encoding works, and that special characters are not malformed.
 		$this->assertStringContainsString('Vantar þinn ungling sjálfstraust í stærðfræði?', $result);
+
+		// Check that rocket-loader.min.js has been removed, as including it breaks landing page redirects.
+		$this->assertStringNotContainsString('rocket-loader.min.js', $result);
 	}
 
 	/**
@@ -6184,6 +6190,9 @@ public function testGetLegacyLandingPageHTML()
 		$result = $this->api->get_landing_page_html($_ENV['CONVERTKIT_API_LEGACY_LANDING_PAGE_URL']);
 		$this->assertNotInstanceOf(WP_Error::class, $result);
 		$this->assertStringContainsString('<form id="ck_subscribe_form" class="ck_subscribe_form" action="https://app.convertkit.com/landing_pages/' . $_ENV['CONVERTKIT_API_LEGACY_LANDING_PAGE_ID'] . '/subscribe" data-remote="true">', $result);
+
+		// Check that rocket-loader.min.js has been removed, as including it breaks landing page redirects.
+		$this->assertStringNotContainsString('rocket-loader.min.js', $result);
 	}
 
 	/**