Merge pull request #11 from ConvertKit/support-coupon-exhaustion

Raise Stripe::InvalidRequestError when attempting to apply an exhausted coupon

Author: mpolakis

Gemfile

@@ -7,6 +7,7 @@ end
 
 group :test do
   gem 'rake'
+  gem 'pry'
 end
 
 gemspec

lib/stripe_mock/request_handlers/subscriptions.rb

@@ -60,6 +60,10 @@ def create_customer_subscription(route, method_url, params, headers)
           coupon = coupons[coupon_id]
 
           if coupon
+            if coupon[:times_redeemed] >= coupon[:max_redemptions]
+              raise Stripe::InvalidRequestError.new("Coupon #{coupon[:id]} is used up and cannot be applied.", 'coupon', http_status: 400)
+            end
+
             add_coupon_to_object(subscription, coupon)
           else
             raise Stripe::InvalidRequestError.new("No such coupon: #{coupon_id}", 'coupon', http_status: 400)
@@ -135,6 +139,10 @@ def create_subscription(route, method_url, params, headers)
           coupon = coupons[coupon_id]
 
           if coupon
+            if coupon[:times_redeemed] >= coupon[:max_redemptions]
+              raise Stripe::InvalidRequestError.new("Coupon #{coupon[:id]} is used up and cannot be applied.", 'coupon', http_status: 400)
+            end
+
             add_coupon_to_object(subscription, coupon)
           else
             raise Stripe::InvalidRequestError.new("No such coupon: #{coupon_id}", 'coupon', http_status: 400)
@@ -198,6 +206,10 @@ def update_subscription(route, method_url, params, headers)
 
           coupon = coupons[coupon_id]
           if coupon
+            if coupon[:times_redeemed] >= coupon[:max_redemptions]
+              raise Stripe::InvalidRequestError.new("Coupon #{coupon[:id]} is used up and cannot be applied.", 'coupon', http_status: 400)
+            end
+
             add_coupon_to_object(subscription, coupon)
           elsif coupon_id == ""
             subscription[:discount] = nil

spec/shared_stripe_examples/subscription_examples.rb

@@ -878,7 +878,7 @@
         metadata: { foo: "bar", example: "yes" },
         default_payment_method: payment_method_card.id,
       )
-      
+
       subscriptions = Stripe::Subscription.list(customer: customer)
       expect(subscriptions.data.first.default_payment_method).to eq(payment_method_card.id)
 
@@ -887,7 +887,7 @@
         default_payment_method: payment_method_sepa.id,
         collection_method: 'send_invoice',
       )
-      
+
       subscriptions = Stripe::Subscription.list(customer: customer)
       expect(subscriptions.data.first.collection_method).to eq('send_invoice')
       expect(subscriptions.data.first.default_payment_method).to eq(payment_method_sepa.id)
@@ -906,6 +906,20 @@
       expect(subscription.discount.coupon.id).to eq(coupon.id)
     end
 
+    it 'when it attempts to add an exhausted coupon' do
+      coupon = stripe_helper.create_coupon(max_redemptions: 1, times_redeemed: 1)
+      customer = Stripe::Customer.create(source: gen_card_tk, plan: plan.id)
+      subscription = Stripe::Subscription.retrieve(customer.subscriptions.data.first.id)
+
+      subscription.coupon = coupon.id
+
+      expect { subscription.save }.to raise_error {|e|
+                                                     expect(e).to be_a Stripe::InvalidRequestError
+                                                     expect(e.http_status).to eq(400)
+                                                     expect(e.message).to eq("Coupon #{coupon.id} is used up and cannot be applied.")
+                                                   }
+    end
+
     it 'when add not exist coupon' do
       customer = Stripe::Customer.create(source: gen_card_tk, plan: plan.id)
       subscription = Stripe::Subscription.retrieve(customer.subscriptions.data.first.id)

spec/spec_helper.rb

@@ -2,6 +2,7 @@
 
 gem 'rspec', '~> 3.1'
 require 'rspec'
+require 'pry'
 require 'stripe'
 require 'stripe_mock'
 require 'stripe_mock/server'