Skip to content

Commit 23388e6

Browse files
bruyeretfinetjul
authored andcommitted
refactor(shareResources): add comments and comment private variables
1 parent 9905080 commit 23388e6

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

Sources/Rendering/OpenGL/ImageMapper/index.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ function vtkOpenGLImageMapper(publicAPI, model) {
8989
!oldOglRenderWindow.isDeleted() &&
9090
oldOglRenderWindow !== model._openGLRenderWindow
9191
) {
92+
// We unregister ourself when the render window changes
9293
unregisterGraphicsResources(oldOglRenderWindow);
9394
}
9495
model.context = model._openGLRenderWindow.getContext();
@@ -1462,10 +1463,10 @@ const DEFAULT_VALUES = {
14621463
lastHaveSeenDepthRequest: false,
14631464
haveSeenDepthRequest: false,
14641465
lastTextureComponents: 0,
1465-
_scalars: null,
1466-
_colorTransferFunc: null,
1467-
_pwFunc: null,
1468-
_labelOutlineThicknessArray: null,
1466+
// _scalars: null,
1467+
// _colorTransferFunc: null,
1468+
// _pwFunc: null,
1469+
// _labelOutlineThicknessArray: null,
14691470
};
14701471

14711472
// ----------------------------------------------------------------------------

Sources/Rendering/OpenGL/ImageResliceMapper/index.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ function vtkOpenGLImageResliceMapper(publicAPI, model) {
8585
!oldOglRenderWindow.isDeleted() &&
8686
oldOglRenderWindow !== model._openGLRenderWindow
8787
) {
88+
// We unregister ourself when the render window changes
8889
unregisterGraphicsResources(oldOglRenderWindow);
8990
}
9091
model.context = model._openGLRenderWindow.getContext();
@@ -1326,9 +1327,9 @@ const DEFAULT_VALUES = {
13261327
colorTexture: null,
13271328
pwfTexture: null,
13281329
_externalOpenGLTexture: false,
1329-
_scalars: null,
1330-
_colorTransferFunc: null,
1331-
_pwFunc: null,
1330+
// _scalars: null,
1331+
// _colorTransferFunc: null,
1332+
// _pwFunc: null,
13321333
};
13331334

13341335
// ----------------------------------------------------------------------------

Sources/Rendering/OpenGL/VolumeMapper/index.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ function vtkOpenGLVolumeMapper(publicAPI, model) {
164164
!oldOglRenderWindow.isDeleted() &&
165165
oldOglRenderWindow !== model._openGLRenderWindow
166166
) {
167+
// We unregister ourself when the render window changes
167168
unregisterGraphicsResources(oldOglRenderWindow);
168169
}
169170
model.context = model._openGLRenderWindow.getContext();
@@ -1894,10 +1895,10 @@ const DEFAULT_VALUES = {
18941895
projectionToView: null,
18951896
avgWindowArea: 0.0,
18961897
avgFrameTime: 0.0,
1897-
_scalars: null,
1898-
_scalarOpacityFunc: null,
1899-
_colorTransferFunc: null,
1900-
_labelOutlineThicknessArray: null,
1898+
// _scalars: null,
1899+
// _scalarOpacityFunc: null,
1900+
// _colorTransferFunc: null,
1901+
// _labelOutlineThicknessArray: null,
19011902
};
19021903

19031904
// ----------------------------------------------------------------------------

0 commit comments

Comments
 (0)