From 9ea61e21f9a6510fbdff44cff0eae1d792708a75 Mon Sep 17 00:00:00 2001 From: MASDXI Date: Wed, 26 Feb 2025 14:45:38 +0700 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20logic=20error=20compare?= =?UTF-8?q?=20start=20and=20end?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- contracts/tokens/ERC721/ERC721EXPBase.sol | 2 +- contracts/tokens/ERC721/interfaces/IERC7858.sol | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/contracts/tokens/ERC721/ERC721EXPBase.sol b/contracts/tokens/ERC721/ERC721EXPBase.sol index acccef4..9fe0034 100644 --- a/contracts/tokens/ERC721/ERC721EXPBase.sol +++ b/contracts/tokens/ERC721/ERC721EXPBase.sol @@ -47,7 +47,7 @@ abstract contract ERC721EXPBase is ERC721, ERC721Enumerable, IERC7858 { } function _updateTimeStamp(uint256 tokenId, uint64 start, uint64 end) internal { - if ((start <= end) && (start != 0) && (end != 0)) { + if (start >= end) { revert ERC7858InvalidTimeStamp(start, end); } _tokensTimeStamp[tokenId].start = start; diff --git a/contracts/tokens/ERC721/interfaces/IERC7858.sol b/contracts/tokens/ERC721/interfaces/IERC7858.sol index e010632..c3425bf 100644 --- a/contracts/tokens/ERC721/interfaces/IERC7858.sol +++ b/contracts/tokens/ERC721/interfaces/IERC7858.sol @@ -15,11 +15,7 @@ interface IERC7858 { * @param startTime The start time of the token (block number or timestamp based on `expiryType`). * @param endTime The end time of the token (block number or timestamp based on `expiryType`). */ - event TokenExpiryUpdated( - uint256 indexed tokenId, - uint256 indexed startTime, - uint256 indexed endTime - ); + event TokenExpiryUpdated(uint256 indexed tokenId, uint256 indexed startTime, uint256 indexed endTime); error ERC7858InvalidTimeStamp(uint256 start, uint256 end);