Merge pull request #684 from juanjemdIos/master

Resolve problem in codemeta export and buildinstrucctions. Fixes #677

Author: dgarijo

src/somef/export/json_export.py

@@ -38,7 +38,6 @@ def save_codemeta_output(repo_data, outfile, pretty=False):
     @param outfile: path where to save the codemeta file
     @param pretty: option to show the JSON results in a nice format
     """
-
     def format_date(date_string):
         date_object = date_parser.parse(date_string)
         return date_object.strftime("%Y-%m-%d")
@@ -67,8 +66,12 @@ def format_date(date_string):
     author_name = None
     if constants.CAT_OWNER in repo_data:
         author_name = repo_data[constants.CAT_OWNER][0][constants.PROP_RESULT][constants.PROP_VALUE]
+    
+    # add a check for the existence of the 'description' property, similar way to most properties in the method.
+    descriptions = None
+    if constants.CAT_DESCRIPTION in repo_data:
+        descriptions = repo_data[constants.CAT_DESCRIPTION]
 
-    descriptions = repo_data[constants.CAT_DESCRIPTION]
     descriptions_text = []
     if descriptions is not None:
         descriptions.sort(key=lambda x: (x[constants.PROP_CONFIDENCE] + (1 if x[constants.PROP_TECHNIQUE] == constants.GITHUB_API else 0)),
@@ -85,12 +88,30 @@ def format_date(date_string):
         for l in repo_data[constants.CAT_LICENSE]:
             if constants.PROP_NAME in l[constants.PROP_RESULT].keys():
                 l_result["name"] = l[constants.PROP_RESULT][constants.PROP_NAME]
+            # else:
+            #     print(f"PROP_NAME key not found in: {l[constants.PROP_RESULT].keys()}")
+
+            # change this structure because is posible l_result["url"] doesnt exist
+            # if "url" not in l_result.keys() and constants.PROP_URL in l[constants.PROP_RESULT].keys(): 
+            #     l_result["url"] = l[constants.PROP_RESULT][constants.PROP_URL] 
+            # # We get the first license we find from the repo 
+            # elif l[constants.PROP_TECHNIQUE] == constants.TECHNIQUE_FILE_EXPLORATION and constants.PROP_SOURCE in l.keys() and "api.github.com" in l_result["url"]: 
+            #     l_result["url"] = l[constants.PROP_SOURCE]
+
+            # checking if PROP_URL is in the keys PROP_RESULT and key "url" is not in results
             if "url" not in l_result.keys() and constants.PROP_URL in l[constants.PROP_RESULT].keys():
-                    l_result["url"] = l[constants.PROP_RESULT][constants.PROP_URL]
-            # We get the first license we find from the repo
-            elif l[constants.PROP_TECHNIQUE] == constants.TECHNIQUE_FILE_EXPLORATION \
-                    and constants.PROP_SOURCE in l.keys() and "api.github.com" in l_result["url"]:
-                l_result["url"] = l[constants.PROP_SOURCE]
+                l_result["url"] = l[constants.PROP_RESULT][constants.PROP_URL]
+            # else:
+            #     print(f"PROP_URL key not found in: {l[constants.PROP_RESULT].keys()}")
+        
+            # Thist block run if url is not found in the previous 
+            if l[constants.PROP_TECHNIQUE] == constants.TECHNIQUE_FILE_EXPLORATION and constants.PROP_SOURCE in l.keys():
+                if "url" in l_result and "api.github.com" in l_result["url"]:
+                    l_result["url"] = l[constants.PROP_SOURCE]
+            else:
+                if "url" not in l_result.keys() and constants.PROP_URL in l[constants.PROP_RESULT].keys():
+                        l_result["url"] = l[constants.PROP_RESULT][constants.PROP_URL]
+
         codemeta_output["license"] = l_result
     if code_repository is not None:
         codemeta_output["codeRepository"] = code_repository
@@ -118,6 +139,7 @@ def format_date(date_string):
                 install_links.append(inst[constants.PROP_SOURCE])
             elif inst[constants.PROP_TECHNIQUE] == constants.TECHNIQUE_FILE_EXPLORATION:
                 install_links.append(inst[constants.PROP_RESULT][constants.PROP_VALUE])
+
     if constants.CAT_DOCUMENTATION in repo_data:
         for inst in repo_data[constants.CAT_DOCUMENTATION]:
             if inst[constants.PROP_TECHNIQUE] == constants.TECHNIQUE_HEADER_ANALYSIS and constants.PROP_SOURCE in inst.keys():

src/somef/test/test_codemeta_gitlab_export.py

@@ -0,0 +1,33 @@
+import os
+import unittest
+from pathlib import Path
+from .. import somef_cli
+from ..utils import constants
+
+test_data_path = str(Path(__file__).parent / "test_data") + os.path.sep
+
+class TestCodemetaGitlabExport(unittest.TestCase):
+    def test_codemeta_gitlab_export(self):
+        """Checks if codemeta file has been exported from a gitlab repo"""
+        somef_cli.run_cli(threshold=0.8,
+                            ignore_classifiers=False,
+                            repo_url='https://gitlab.com/escape-ossr/eossr',
+                            doc_src=None,
+                            in_file=None,
+                            output=None,
+                            graph_out=None,
+                            graph_format="turtle",
+                            codemeta_out=test_data_path + 'test_gitlab.json',
+                            pretty=False,
+                            missing=False)
+        
+        json_file_path = test_data_path + "test_gitlab.json"
+        # check if the file has been created in the correct path
+        assert os.path.exists(json_file_path), f"File {json_file_path} doesn't exist."
+
+        text_file = open(test_data_path + "test_gitlab.json", "r")
+        data = text_file.read()
+        text_file.close()
+        # check if has been correctly created with the normal structure
+        assert data.find(constants.CAT_IDENTIFIER) > 0
+        os.remove(test_data_path + "test_gitlab.json")