Merge pull request #4 from Kocal/fix/enable-tty-if-supported

Author: Kocal

.github/workflows/ci.yaml

@@ -99,4 +99,55 @@ jobs:
         run: symfony php vendor/bin/phpstan analyze
 
       - name: Run PHPUnit
-        run: symfony php vendor/bin/phpunit
+        run: symfony php vendor/bin/phpunit
+  
+  e2e:
+    name: E2E
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.2
+          tools: symfony-cli
+
+      - name: Install Composer dependencies
+        run: symfony composer install --prefer-dist --no-interaction --no-progress
+
+      - name: Create a new Symfony project and install kocal/biome-js-bundle
+        run: |
+          git config --global user.email "[email protected]"
+          git config --global user.name "Hugo Alliaume"
+          symfony new my_app --webapp
+          cd my_app
+          symfony composer config minimum-stability dev
+          symfony composer config repositories.biome-js-bundle '{"type":"path", "url":"../","options":{"symlink":true}}'
+          symfony composer require 'kocal/biome-js-bundle:*' --dev
+          cat << EOF > biome.json
+          { 
+            "files": {
+              "ignore": [
+                "composer.json",
+                "assets/vendor/*",
+                "vendor/*",
+                "public/bundles/*"
+              ]
+            }
+          }
+          EOF
+
+      - name: Run Biome CI, which should fails
+        run: symfony console biome:ci .
+        continue-on-error: true
+        working-directory: my_app
+
+      - name: Run Biome Check, and apply fixes
+        run: symfony console biome:check . --apply
+        working-directory: my_app
+
+      - name: Run Biome CI, which should now pass
+        run: symfony console biome:ci .
+        working-directory: my_app
+

.gitignore

@@ -1,3 +1,5 @@
 /vendor/
 composer.lock
 .phpunit.result.cache
+
+my_app/

config/services.php

@@ -5,14 +5,15 @@
 use Kocal\BiomeJsBundle\Command\BiomeJsCheckCommand;
 use Kocal\BiomeJsBundle\Command\BiomeJsCiCommand;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use Symfony\Component\Process\Process;
 use function Symfony\Component\DependencyInjection\Loader\Configurator\abstract_arg;
 use function Symfony\Component\DependencyInjection\Loader\Configurator\param;
 use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
 
 return static function (ContainerConfigurator $container): void {
     $container->parameters()
         // Internal parameter to enable/disable TTY mode, useful for tests (if someone has a better idea, feel free to suggest it!)
-        ->set('biomejs.use_tty', true)
+        ->set('biomejs.use_tty', Process::isTtySupported())
     ;
 
     $container->services()
@@ -40,4 +41,4 @@
             service('biomejs'),
         ])
         ->tag('console.command');
-};
+};

src/BiomeJs.php

@@ -17,7 +17,7 @@ public function __construct(
     ) {
     }
 
-    public function setOutput(SymfonyStyle|null $output): void
+    public function setOutput(?SymfonyStyle $output): void
     {
         $this->output = $output;
     }
@@ -33,7 +33,7 @@ public function check(
         bool $organizeImportsEnabled,
         bool $staged,
         bool $changed,
-        string|null $since,
+        ?string $since,
         array $path,
     ): Process {
         $arguments = [];
@@ -81,7 +81,7 @@ public function ci(
         bool $linterEnabled,
         bool $organizeImportsEnabled,
         bool $changed,
-        string|null $since,
+        ?string $since,
         array $path,
     ): Process {
         $arguments = [];

src/BiomeJsBinary.php

@@ -11,20 +11,20 @@
 
 final class BiomeJsBinary
 {
-    private SymfonyStyle|null $output = null;
+    private ?SymfonyStyle $output = null;
     private HttpClientInterface $httpClient;
-    private string|null $cachedVersion = null;
+    private ?string $cachedVersion = null;
 
     public function __construct(
         private readonly string $cwd,
         private readonly string $binaryDownloadDir,
-        private readonly string|null $binaryVersion,
-        HttpClientInterface|null $httpClient = null,
+        private readonly ?string $binaryVersion,
+        ?HttpClientInterface $httpClient = null,
     ) {
         $this->httpClient = $httpClient ?? HttpClient::create();
     }
 
-    public function setOutput(SymfonyStyle|null $output): void
+    public function setOutput(?SymfonyStyle $output): void
     {
         $this->output = $output;
     }