kong ingress duplicate CRD installation

[NissesSenap]

When using ArgoCD and the ingress helm chart you will get the following error
RepeatedResourceWarning Resource apiextensions.k8s.io/CustomResourceDefinition//ingressclassparameterses.configuration.konghq.com appeared 2 times among application resources.

I think this is because currently, ingress uses the kong helm chart as a subChart twice, but don't disable the CRD installation in the gateway.

See:

charts/charts/ingress/values.yaml

Lines 41 to 42 in e09fd7a

	ingressController:
	enabled: false

and

charts/charts/kong/templates/custom-resource-definitions.yaml

Lines 1 to 4 in e09fd7a

	{{- $installCRDs := false -}}
	{{- if (hasKey .Values.ingressController "installCRDs") -}}
	{{/* Explicitly set, honor whatever's set */}}
	{{- $installCRDs = .Values.ingressController.installCRDs -}}

I'm unsure if this actually works since we also have the folder called CRDs https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you, but I'm a bit unsure on how helm/argocd works in this case.

[NissesSenap]

In the end, I solved this locally by setting skipCRDs on my helm chat. And I created a separate ArgoCD application that applies https://raw.githubusercontent.com/Kong/charts/6c1421bf2f4ccbd96d14eb49ed9438bbf9bef800/charts/kong/crds/custom-resource-definitions.yaml which matches the version of the CRDs in the helm chart

[rainest]

Yeah, don't know if there's anything we can do here--AFAIK there is no way to selectively disable CRDs for only one of the subcharts, and the attached issue supports that.

We want to ultimately consolidate back into a single chart, which would clear the problem. Your current workaround is what I'd suggest, with the slight difference that you should use the KIC URL for your particular controller version, which will be easier than picking out a particular chart commit.

[NissesSenap]

@rainest is there any issue opened about changing back in to a single chart that I can follow along in?

[rainest]

#976 and #921, effectively.