-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kotlin Multiplatform Plugin for JVM only #645
Comments
Also I am using a beta KSP version ( |
Oh, hi! We definitely want to support JVM target in multiplatform projects, so thank you for reporting this. I think it used to work, but now deprecated and needs to be fixed. I would appreciate a PR
|
Hello! Just created the PR. I might also create another issue/PR later about specifying custom configurations. For example, I have a commonJvmAndroid target (which I expect can work with dataframes since android is still java) so |
There is already an issue for supporting multiplatform. This is issue is a (possibly) much smaller and simpler request. I am requesting support for gradle modules that are jvm-only, but still use the kotlin multiplatform gradle plugin instead of the regular
kotlin("jvm")
gradle plugin.I am just getting started with kotlin dataframes so I don't yet know what degree of support there is, if any, already for the using dataframes in a multiplatform project that only defines a jvm target. However, I can say that upon trying I right away received a warning that indicated to me that there may not be support for this type of project setup:
In the best case scenario, maybe kotlin dataframes already mostly supports the kotlin multiplatform plugin and this is just an issue where dataframes needs to make a small change to respect this warning. If that is true, here is my suggestion:
In
ConvenienceSchemaGeneratorPlugin
in the line that doestarget.configurations.getByName("ksp").dependencies.add
, add add a check for if the kotlin multiplatform plugin is applied. If it is, just use the configuration "kspJvm" instead. And then further down, use "kspJvmTest" instead of "kspTest".Best case scenario, its just a few lines of code. I could do the PR myself, but if someone more familiar with this project wants to please go ahead as I'm still getting my first look at it.
The text was updated successfully, but these errors were encountered: