Simplify build number detection

Author: ileasile

build-plugin/src/build/RootSettingsExtension.kt

@@ -175,17 +175,10 @@ class RootSettingsExtension(
 
         val defaultBuildNumber = "$baseVersion.$buildCounter$devAddition"
 
-        return if (!buildNumber.matches(BUILD_NUMBER_REGEX)) {
-            val versionFile = artifactsDir.resolve(versionFileName)
-            if (versionFile.exists()) {
-                val lines = versionFile.readLines()
-                assert(lines.isNotEmpty()) { "There should be at least one line in VERSION file" }
-                lines.first().trim()
-            } else {
-                defaultBuildNumber
-            }
-        } else {
+        return if (buildNumber.matches(BUILD_NUMBER_REGEX)) {
             buildNumber
+        } else {
+            defaultBuildNumber
         }
     }
 

teamcityBuildNumber.gradle.kts

@@ -0,0 +1,19 @@
+
+
+tasks.register("detectVersionsForTC") {
+    outputs.upToDateWhen { false }
+
+    doLast {
+        println("##teamcity[buildNumber '${ detectVersion() }']")
+    }
+}
+
+private fun detectVersion(): String {
+    val baseVersion = project.property("baseVersion") as String
+    val buildCounter = project.property("build.counter") as String
+    val devCounter = project.findProperty("build.devCounter") as? String
+    val isOnProtectedBranch = (project.property("build.branch") as String) == "master"
+    val devAddition = if (isOnProtectedBranch && devCounter == null) "" else ".dev${devCounter ?: "1"}"
+
+    return "$baseVersion.$buildCounter$devAddition"
+}