Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add browser utility #3

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: add browser utility #3

merged 1 commit into from
Apr 5, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Apr 5, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

add browser utility which supports open a given url in web browser

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@adohe adohe added the feature New feature label Apr 5, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8568110942

Details

  • 8 of 14 (57.14%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 79.603%

Changes Missing Coverage Covered Lines Changed/Added Lines %
browser/browser.go 8 14 57.14%
Totals Coverage Status
Change from base Build 8556015894: -0.9%
Covered Lines: 281
Relevant Lines: 353

💛 - Coveralls

@adohe adohe force-pushed the feat_web_browser branch from 4e13f81 to 05ccea4 Compare April 5, 2024 10:08
@adohe adohe merged commit 0a7c1b9 into main Apr 5, 2024
5 checks passed
@adohe adohe deleted the feat_web_browser branch April 5, 2024 10:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants