Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooperate/GitHub chunqi faultinjection #29

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

spring-young
Copy link
Collaborator

What type of PR is this?

feature

What this PR does / why we need it:

fix some errors and add a feature
fixs:
fix circuit breaker update condition
fix circuit and fault store update
feature:
add fault normal and regexp rules

Which issue(s) this PR fixes:

fix circuit breaker update condition
fix circuit and fault store update

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (7efa14b) 42.08% compared to head (3e5d66d) 42.82%.

Files Patch % Lines
pkg/proxy/faultinjection/store.go 50.00% 16 Missing and 2 partials ⚠️
pkg/proxy/faultinjection/manager.go 70.58% 14 Missing and 1 partial ⚠️
pkg/proxy/http/http_proxy.go 40.00% 14 Missing and 1 partial ⚠️
pkg/proxy/circuitbreaker/manager.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   42.08%   42.82%   +0.73%     
==========================================
  Files          26       26              
  Lines        2844     2928      +84     
==========================================
+ Hits         1197     1254      +57     
- Misses       1539     1562      +23     
- Partials      108      112       +4     
Flag Coverage Δ
unittests 42.82% <59.20%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spring-young spring-young force-pushed the cooperate/github-chunqi-faultinjection branch from 5ddd910 to 3e5d66d Compare January 19, 2024 09:38
Copy link
Collaborator

@Eikykun Eikykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Eikykun Eikykun merged commit 2e8b51b into main Jan 22, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants