From 906dbe2b1d1b3ab3f05042f8d0b0ceb200e33145 Mon Sep 17 00:00:00 2001 From: hexin <574252631@qq.com> Date: Thu, 19 Sep 2024 11:52:22 +0800 Subject: [PATCH] update opj status in releaseTargets (#280) --- pkg/controllers/operationjob/operationjob_manager.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/controllers/operationjob/operationjob_manager.go b/pkg/controllers/operationjob/operationjob_manager.go index a6e2892f..4b34e0ba 100644 --- a/pkg/controllers/operationjob/operationjob_manager.go +++ b/pkg/controllers/operationjob/operationjob_manager.go @@ -235,7 +235,7 @@ func (r *ReconcileOperationJob) releaseTargets(ctx context.Context, operationJob return err } - _, err = controllerutils.SlowStartBatch(len(candidates), controllerutils.SlowStartInitialBatchSize, false, func(i int, _ error) error { + _, releaseErr := controllerutils.SlowStartBatch(len(candidates), controllerutils.SlowStartInitialBatchSize, false, func(i int, _ error) error { candidate := candidates[i] err := actionHandler.ReleaseTarget(ctx, candidate, operationJob) // mark candidate as failed if not finished @@ -249,7 +249,9 @@ func (r *ReconcileOperationJob) releaseTargets(ctx context.Context, operationJob } return err }) - return err + operationJob.Status = r.calculateStatus(operationJob, candidates) + updateErr := r.updateStatus(ctx, operationJob) + return controllerutils.AggregateErrors([]error{releaseErr, updateErr}) } func (r *ReconcileOperationJob) cleanCandidateOpsLifecycle(ctx context.Context, forced bool, candidate *OpsCandidate, operationJob *appsv1alpha1.OperationJob) error {