Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize loopless modification #745

Closed
wants to merge 5 commits into from
Closed

Generalize loopless modification #745

wants to merge 5 commits into from

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented Feb 12, 2023

Change loopless so that it can be applied to any model, e.g. enzyme constrained models

@stelmo
Copy link
Collaborator Author

stelmo commented Feb 14, 2023

I could add an argument to this modification requesting the row indices that correspond to metabolites in the order of metabolites

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 88.28% // Head: 88.30% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2a889ac) compared to base (65f79be).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #745      +/-   ##
==========================================
+ Coverage   88.28%   88.30%   +0.01%     
==========================================
  Files          85       85              
  Lines        2075     2078       +3     
==========================================
+ Hits         1832     1835       +3     
  Misses        243      243              
Impacted Files Coverage Δ
src/analysis/modifications/loopless.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stelmo
Copy link
Collaborator Author

stelmo commented Feb 14, 2023

/format

@stelmo stelmo requested a review from exaexa February 14, 2023 20:33
triggered by @stelmo on PR #745
@github-actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as 2a889ac

@exaexa exaexa added this to the v2.0 milestone Feb 16, 2023
@stelmo stelmo added the do not merge When a PR is labelled as such, do not merge label Feb 16, 2023
@stelmo
Copy link
Collaborator Author

stelmo commented Dec 17, 2023

continued in #810

@stelmo stelmo closed this Dec 17, 2023
@stelmo stelmo deleted the mo-general-loopless branch January 4, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge When a PR is labelled as such, do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants