Skip to content

Commit 52165f2

Browse files
committed
fix: remove persistence nullability
1 parent ba16297 commit 52165f2

File tree

2 files changed

+1
-28
lines changed

2 files changed

+1
-28
lines changed

src/LEGO.AsyncAPI.Bindings/Pulsar/PulsarChannelBinding.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public class PulsarChannelBinding : ChannelBinding<PulsarChannelBinding>
1919
/// <summary>
2020
/// persistence of the topic in Pulsar persistent or non-persistent.
2121
/// </summary>
22-
public Persistence? Persistence { get; set; }
22+
public Persistence Persistence { get; set; }
2323

2424
/// <summary>
2525
/// Topic compaction threshold given in bytes.

test/LEGO.AsyncAPI.Tests/Bindings/Pulsar/PulsarBindings_Should.cs

-27
Original file line numberDiff line numberDiff line change
@@ -88,33 +88,6 @@ public void PulsarChannelBindingNamespaceDefaultToNull()
8888
Assert.AreEqual(null, ((PulsarChannelBinding)binding.Bindings["pulsar"]).Namespace);
8989
}
9090

91-
[Test]
92-
public void PulsarChannelBindingPropertiesExceptNamespaceDefaultToNull()
93-
{
94-
// Arrange
95-
var actual =
96-
"""
97-
bindings:
98-
pulsar:
99-
namespace: staging
100-
""";
101-
102-
// Act
103-
// Assert
104-
var settings = new AsyncApiReaderSettings();
105-
settings.Bindings = BindingsCollection.Pulsar;
106-
var binding = new AsyncApiStringReader(settings).ReadFragment<AsyncApiChannel>(actual, AsyncApiVersion.AsyncApi2_0, out _);
107-
var pulsarBinding = ((PulsarChannelBinding)binding.Bindings["pulsar"]);
108-
109-
Assert.AreEqual("staging", pulsarBinding.Namespace);
110-
Assert.AreEqual(null, pulsarBinding.Persistence);
111-
Assert.AreEqual(null, pulsarBinding.Compaction);
112-
Assert.AreEqual(null, pulsarBinding.GeoReplication);
113-
Assert.AreEqual(null, pulsarBinding.Retention);
114-
Assert.AreEqual(null, pulsarBinding.TTL);
115-
Assert.AreEqual(null, pulsarBinding.Deduplication);
116-
}
117-
11891
[Test]
11992
public void PulsarServerBinding_WithFilledObject_SerializesAndDeserializes()
12093
{

0 commit comments

Comments
 (0)