Skip to content

Commit f00ea1b

Browse files
authored
Merge pull request #75 from LRWeber/countdown-cleanup
Simplified GitHub scraper wait countdown.
2 parents 95d721b + 40e6c51 commit f00ea1b

File tree

1 file changed

+8
-19
lines changed

1 file changed

+8
-19
lines changed

scraper/github/queryManager.py

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ def queryGitHub(
318318

319319
self._countdown(
320320
self.retryDelay,
321-
printString="Query accepted but not yet processed. Trying again in %*dsec...",
321+
printString="Query accepted but not yet processed. Trying again in %*d seconds...",
322322
verbose=(verbosity >= 0),
323323
)
324324
return self.queryGitHub(
@@ -347,7 +347,7 @@ def queryGitHub(
347347

348348
self._countdown(
349349
self.retryDelay,
350-
printString="Server error. Trying again in %*dsec...",
350+
printString="Server error. Trying again in %*d seconds...",
351351
verbose=(verbosity >= 0),
352352
)
353353
return self.queryGitHub(
@@ -392,7 +392,7 @@ def queryGitHub(
392392
)
393393
self._countdown(
394394
self.retryDelay,
395-
printString="Unknown API error. Trying again in %*dsec...",
395+
printString="Unknown API error. Trying again in %*d seconds...",
396396
verbose=(verbosity >= 0),
397397
)
398398
return self.queryGitHub(
@@ -571,31 +571,20 @@ def _awaitReset(self, utcTimeStamp, verbose=True):
571571
def _countdown(
572572
self, waitTime=0, printString="Waiting %*d seconds...", verbose=True
573573
):
574-
"""Makes a pretty countdown.
574+
"""Prints a message and waits.
575575
576576
Args:
577-
gitquery (str): The query or endpoint itself.
578-
Examples:
579-
query: 'query { viewer { login } }'
580-
endpoint: '/user'
577+
waitTime (Optional[int]): Number of seconds to wait. Defaults to 0.
581578
printString (Optional[str]): A counter message to display.
582-
Defaults to 'Waiting %*d seconds...'
579+
Defaults to "Waiting %*d seconds...".
583580
verbose (Optional[bool]): If False, all extra printouts will be
584581
suppressed. Defaults to True.
585582
586583
"""
587584
if waitTime <= 0:
588585
waitTime = self.retryDelay
589-
for remaining in range(waitTime, 0, -1):
590-
_vPrint(
591-
verbose,
592-
"\r" + printString % (len(str(waitTime)), remaining),
593-
end="",
594-
flush=True,
595-
)
596-
time.sleep(1)
597-
if verbose:
598-
_vPrint(verbose, "\r" + printString % (len(str(waitTime)), 0))
586+
_vPrint(verbose, printString % (len(str(waitTime)), waitTime))
587+
time.sleep(waitTime)
599588

600589

601590
class DataManager:

0 commit comments

Comments
 (0)