fix bank terminal auth check

Author: techno-sam

changelog.md

@@ -5,7 +5,7 @@ Additions
 - Entry
 
 Fixes
-- Entry
+- Bank terminals properly check authorization now
 
 Removals
 - Entry

common/src/main/java/dev/ithundxr/createnumismatics/content/bank/BankTerminalBlock.java

@@ -67,23 +67,28 @@ protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockSt
 
     @SuppressWarnings("StatementWithEmptyBody")
     @Override
-    public InteractionResult use(BlockState state, Level level, BlockPos pos, Player player, InteractionHand hand, BlockHitResult hit) {
+    public @NotNull InteractionResult use(@NotNull BlockState state, Level level, @NotNull BlockPos pos,
+                                          @NotNull Player player, @NotNull InteractionHand hand,
+                                          @NotNull BlockHitResult hit) {
         if (level.isClientSide)
             return InteractionResult.SUCCESS;
 
         ItemStack handStack = player.getItemInHand(hand);
 
         BankAccount account = null;
 
-        if (NumismaticsTags.AllItemTags.CARDS.matches(handStack) && CardItem.isBound(handStack)
-            && (account = Numismatics.BANK.getAccount(CardItem.get(handStack))) != null && account.isAuthorized(player)) {
-            // intentionally left blank
+        if (NumismaticsTags.AllItemTags.CARDS.matches(handStack) && CardItem.isBound(handStack)) {
+            account = Numismatics.BANK.getAccount(CardItem.get(handStack));
         }
         if (account == null) {
             account = Numismatics.BANK.getAccount(player);
         }
 
-        Utils.openScreen((ServerPlayer) player, account, account::sendToMenu);
-        return InteractionResult.SUCCESS;
+        if (account.isAuthorized(player)) {
+            Utils.openScreen((ServerPlayer) player, account, account::sendToMenu);
+            return InteractionResult.SUCCESS;
+        } else {
+            return InteractionResult.FAIL;
+        }
     }
 }