Skip to content

Commit 905acbe

Browse files
committed
test: add test for new check
1 parent 519113c commit 905acbe

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

crates/types/src/operator_metadata.rs

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ impl OperatorMetadata {
107107
if path.extension().map(|ext| ext != "png").unwrap_or(true) {
108108
return Err(LogoUrlInvalidImageExtension);
109109
}
110+
// Check the server returns content with a "image/png" mime type
110111
let response = reqwest::get(&self.logo).await.unwrap();
111112
let body = response.bytes().await.unwrap();
112113

@@ -270,13 +271,21 @@ mod tests {
270271
}
271272

272273
#[tokio::test]
273-
async fn test_invalid_wrong_image_format() {
274+
async fn test_invalid_logo_wrong_image_format() {
274275
let mut metadata = get_default_metadata();
275276
metadata.logo = "https://test.com/test.svg".to_string();
276277
let err = metadata.validate().await.unwrap_err();
277278
assert_eq!(err, OperatorMetadataError::LogoUrlInvalidImageExtension);
278279
}
279280

281+
#[tokio::test]
282+
async fn test_invalid_logo_invalid_mime_type() {
283+
let mut metadata = get_default_metadata();
284+
metadata.logo = "https://goerli-operator-metadata.s3.amazonaws.com/cat.png".to_string();
285+
let err = metadata.validate().await.unwrap_err();
286+
assert_eq!(err, OperatorMetadataError::LogoUrlInvalidMimeType);
287+
}
288+
280289
#[tokio::test]
281290
async fn test_invalid_website_url_1() {
282291
let mut metadata = get_default_metadata();

0 commit comments

Comments
 (0)