From 1d9fc5ab15e8a1e9baa85ac3bbcd2393d11d7fab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Gr=C3=BCner?= <47506558+MegaRedHand@users.noreply.github.com> Date: Tue, 14 Jan 2025 16:00:04 -0300 Subject: [PATCH 1/7] docs: add error message for `cargo test` on darwin --- README.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 7cd812115..0a030aad1 100644 --- a/README.md +++ b/README.md @@ -76,7 +76,13 @@ You need `foundry` to successfully run it. cargo test ``` -On Mac, you might need to pull the foundry image manually specifying the platform with: +On Mac, you might get an error similar to: + +```bash +Error starting anvil container: Client(PullImage { descriptor: "ghcr.io/foundry-rs/foundry:latest", err: DockerStreamError { error: "no matching manifest for linux/arm64/v8 in the manifest list entries" } }) +``` + +In that case, you'll need to pull the foundry image for the `amd64` platform with: ```bash docker pull --platform amd64 foundry-rs/foundry From 24b4637ddce44ecfd9d4150ab7ece85409fa6dbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Gr=C3=BCner?= <47506558+MegaRedHand@users.noreply.github.com> Date: Tue, 14 Jan 2025 16:02:35 -0300 Subject: [PATCH 2/7] docs: fix command for pulling foundry image --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0a030aad1..269e34c5a 100644 --- a/README.md +++ b/README.md @@ -85,7 +85,7 @@ Error starting anvil container: Client(PullImage { descriptor: "ghcr.io/foundry- In that case, you'll need to pull the foundry image for the `amd64` platform with: ```bash -docker pull --platform amd64 foundry-rs/foundry +docker pull --platform linux/amd64/v8 ghcr.io/foundry-rs/foundry:latest ``` Sometimes the bindings fail due to containing botched doctests. From 1746af8cb7768001b33eea4bafcadd3a3f7c993d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Gr=C3=BCner?= <47506558+MegaRedHand@users.noreply.github.com> Date: Tue, 14 Jan 2025 16:07:05 -0300 Subject: [PATCH 3/7] ci: use ubuntu-22.04 to avoid docker error --- .github/workflows/integration.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 2b7b09325..5ecbcfeb6 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -46,7 +46,7 @@ jobs: test: name: Run Tests - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 env: HOLESKY_WS_URL: ${{ secrets.HOLESKY_WS_URL }} HOLESKY_HTTP_URL: ${{ secrets.HOLESKY_HTTP_URL }} @@ -94,4 +94,4 @@ jobs: uses: actions/upload-artifact@v4 with: name: coverage-summary - path: coverage.zip \ No newline at end of file + path: coverage.zip From 6f1f23353f8ece0ad8e7f8a8cea7382aa46e633a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Gr=C3=BCner?= <47506558+MegaRedHand@users.noreply.github.com> Date: Tue, 14 Jan 2025 16:36:23 -0300 Subject: [PATCH 4/7] chore: sync two readmes --- crates/eigensdk/README.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/crates/eigensdk/README.md b/crates/eigensdk/README.md index 7cd812115..269e34c5a 100644 --- a/crates/eigensdk/README.md +++ b/crates/eigensdk/README.md @@ -76,10 +76,16 @@ You need `foundry` to successfully run it. cargo test ``` -On Mac, you might need to pull the foundry image manually specifying the platform with: +On Mac, you might get an error similar to: ```bash -docker pull --platform amd64 foundry-rs/foundry +Error starting anvil container: Client(PullImage { descriptor: "ghcr.io/foundry-rs/foundry:latest", err: DockerStreamError { error: "no matching manifest for linux/arm64/v8 in the manifest list entries" } }) +``` + +In that case, you'll need to pull the foundry image for the `amd64` platform with: + +```bash +docker pull --platform linux/amd64/v8 ghcr.io/foundry-rs/foundry:latest ``` Sometimes the bindings fail due to containing botched doctests. From f14f425bbae242074500261ec8ee279be7b0aa72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Gr=C3=BCner?= <47506558+MegaRedHand@users.noreply.github.com> Date: Wed, 15 Jan 2025 11:06:57 -0300 Subject: [PATCH 5/7] Revert "ci: use ubuntu-22.04 to avoid docker error" This reverts commit 1746af8cb7768001b33eea4bafcadd3a3f7c993d. --- .github/workflows/integration.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 5ecbcfeb6..2b7b09325 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -46,7 +46,7 @@ jobs: test: name: Run Tests - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest env: HOLESKY_WS_URL: ${{ secrets.HOLESKY_WS_URL }} HOLESKY_HTTP_URL: ${{ secrets.HOLESKY_HTTP_URL }} @@ -94,4 +94,4 @@ jobs: uses: actions/upload-artifact@v4 with: name: coverage-summary - path: coverage.zip + path: coverage.zip \ No newline at end of file From 2dc5e5812b1d7c1c68db77196a75a1e8a67a37c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Gr=C3=BCner?= <47506558+MegaRedHand@users.noreply.github.com> Date: Wed, 15 Jan 2025 11:11:06 -0300 Subject: [PATCH 6/7] docs: merge `cargo test` and `exclude` flag version --- README.md | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/README.md b/README.md index 269e34c5a..59d46bdec 100644 --- a/README.md +++ b/README.md @@ -73,7 +73,7 @@ To test locally :- You need `foundry` to successfully run it. ```bash -cargo test +cargo test --workspace --exclude eigen-utils ``` On Mac, you might get an error similar to: @@ -88,13 +88,6 @@ In that case, you'll need to pull the foundry image for the `amd64` platform wit docker pull --platform linux/amd64/v8 ghcr.io/foundry-rs/foundry:latest ``` -Sometimes the bindings fail due to containing botched doctests. -You can exclude them from the test run with: - -```bash -cargo test --workspace --exclude eigen-utils -``` - At least 1 `approving` review is required to merge the PR. ### lint From b8db7ea0f57572a2c2cc114505de452332e3dfab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Gr=C3=BCner?= <47506558+MegaRedHand@users.noreply.github.com> Date: Wed, 15 Jan 2025 11:11:41 -0300 Subject: [PATCH 7/7] chore: sync two readmes --- crates/eigensdk/README.md | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/crates/eigensdk/README.md b/crates/eigensdk/README.md index 269e34c5a..59d46bdec 100644 --- a/crates/eigensdk/README.md +++ b/crates/eigensdk/README.md @@ -73,7 +73,7 @@ To test locally :- You need `foundry` to successfully run it. ```bash -cargo test +cargo test --workspace --exclude eigen-utils ``` On Mac, you might get an error similar to: @@ -88,13 +88,6 @@ In that case, you'll need to pull the foundry image for the `amd64` platform wit docker pull --platform linux/amd64/v8 ghcr.io/foundry-rs/foundry:latest ``` -Sometimes the bindings fail due to containing botched doctests. -You can exclude them from the test run with: - -```bash -cargo test --workspace --exclude eigen-utils -``` - At least 1 `approving` review is required to merge the PR. ### lint