Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional features and improvements? #1

Open
5 tasks
nicolasgarnier opened this issue Oct 2, 2017 · 6 comments
Open
5 tasks

Additional features and improvements? #1

nicolasgarnier opened this issue Oct 2, 2017 · 6 comments

Comments

@nicolasgarnier
Copy link

nicolasgarnier commented Oct 2, 2017

Hey @THPubs !

I'm Nicolas and I work on the Firebase team.

I just noticed your middleware. It's nice work! :)

I was wondering if you would be willing to implement additional features? I was about to release a Firebase Middleware myself but we'd rather build on top of the community's work if it exists :)

Here is the improvements that would be awesome:

  • Allowing The ID Token to be passed in Cookies too (rather than just auth headers).
  • Configurable Cookies names.
  • Requires the keyword Bearer in the Authentication header since that's more consistent with ID Token authentication specs.
  • If no Service accounts file is passed then instantiate a Firebase admin instance using the default app credentials (available in Google Cloud Environment) automatically.
  • Option to generate Custom auth tokens for the authenticated User.

I have implemented all these features in this file: https://github.com/nicolasgarnier/friendlypix-web-react/blob/master/microservices/firebase-express-middleware.js feel free to check it out!

Would you be willing to implement these or opened to contribution for me (I could send a Pull Request with this code)?

I'd like to use these in some blog post/article I will write up later on and in some official Firebase sample which is why I'm looking for all these features :)

Cheers!

@nicolasgarnier
Copy link
Author

Reached out to you by email instead

@THPubs
Copy link
Member

THPubs commented Nov 5, 2017

Hi @nicolasgarnier. Really Sorry I missed your email. I check and send a reply as soon as possible! I would be happy to help you guys.

@THPubs THPubs reopened this Nov 5, 2017
@rustinlewis
Copy link

rustinlewis commented Dec 17, 2017

Did you guys ever implement this? I'm not seeing any pull requests.

@THPubs
Copy link
Member

THPubs commented Dec 18, 2017

@nicolasgarnier Please let me know whether you can look at it or not 😄

@rustinlewis What are the exact features you are looking for?

@ashline
Copy link

ashline commented Aug 18, 2018

any prospects of this being moved forward?

@THPubs
Copy link
Member

THPubs commented Aug 21, 2018

@ashline I'm trying my best to find some time for this but you are more than welcome to try an add those features. Simply make a pull request and I will merge it if everything is ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants