-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional features and improvements? #1
Comments
Reached out to you by email instead |
Hi @nicolasgarnier. Really Sorry I missed your email. I check and send a reply as soon as possible! I would be happy to help you guys. |
Did you guys ever implement this? I'm not seeing any pull requests. |
@nicolasgarnier Please let me know whether you can look at it or not 😄 @rustinlewis What are the exact features you are looking for? |
any prospects of this being moved forward? |
@ashline I'm trying my best to find some time for this but you are more than welcome to try an add those features. Simply make a pull request and I will merge it if everything is ok! |
Hey @THPubs !
I'm Nicolas and I work on the Firebase team.
I just noticed your middleware. It's nice work! :)
I was wondering if you would be willing to implement additional features? I was about to release a Firebase Middleware myself but we'd rather build on top of the community's work if it exists :)
Here is the improvements that would be awesome:
Bearer
in the Authentication header since that's more consistent with ID Token authentication specs.I have implemented all these features in this file: https://github.com/nicolasgarnier/friendlypix-web-react/blob/master/microservices/firebase-express-middleware.js feel free to check it out!
Would you be willing to implement these or opened to contribution for me (I could send a Pull Request with this code)?
I'd like to use these in some blog post/article I will write up later on and in some official Firebase sample which is why I'm looking for all these features :)
Cheers!
The text was updated successfully, but these errors were encountered: