Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response model refactor #23

Open
LearningProcesss opened this issue Jan 29, 2022 · 1 comment
Open

Response model refactor #23

LearningProcesss opened this issue Jan 29, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@LearningProcesss
Copy link
Owner

LearningProcesss commented Jan 29, 2022

Response model refactor to better handle possible BGG internal server error (502) or rejection like #18, #25, #38

proposal idea

interface BggResponse<T>{
   error: string
   status: number
   data: T[]
}
@LearningProcesss LearningProcesss self-assigned this Jan 29, 2022
@LearningProcesss LearningProcesss added the enhancement New feature or request label Jan 29, 2022
@LearningProcesss LearningProcesss added this to the prio 0 - round one milestone Jan 29, 2022
@ericpoulinnz
Copy link

@LearningProcesss something like this would be hugely helpful for my team. Last night many users where throwing a 202 error for me. I could see that when calling the API directly. However through this library I only got an empty response after some time.

Knowing that there was an error, and the error code is very important to be able to give the user correct feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants