Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Querying collections fails when trying to include stats #46

Closed
ericpoulinnz opened this issue May 22, 2023 · 3 comments · Fixed by #47
Closed

Querying collections fails when trying to include stats #46

ericpoulinnz opened this issue May 22, 2023 · 3 comments · Fixed by #47
Assignees
@LearningProcesss
Labels
bug Something isn't working released

Comments

@ericpoulinnz
Copy link

I am trying to query a user's collection. It works fine when I just pass up a username, but as soon as I add "stats: 1" it just hangs (and I seem to get no errors in the console). It seems to be any username I try, but for one that definitely breaks, try Vitho

const params: ICollectionRequest = {
    username,
    stats: 1, // <- only works when this is removed
  };
  await bggClient.collection.query(params);

Thank you for this package, works really well generally.
@LearningProcesss LearningProcesss self-assigned this May 27, 2023
@LearningProcesss LearningProcesss added the bug Something isn't working label May 27, 2023
@darekkay
Copy link

darekkay commented Jun 3, 2023

I have the same issue, but I get an error message:

Unknown property "stats" for BggCollectionItemDto

Seems to be related to #19, #32 and #33

LearningProcesss added a commit that referenced this issue Jun 18, 2023
@LearningProcesss
feat: add stats dto to collection item
a9643e8 
Add deserialization for:
- BggCollectionItemDto.conditiontext
- BggCollectionItemDto.stats

Github: Close #46
@LearningProcesss LearningProcesss linked a pull request Jun 18, 2023 that will close this issue
Add conditiontext and stats to collection #47
Merged
github-actions bot pushed a commit that referenced this issue Jun 18, 2023
@semantic-release-bot
chore(release): 1.8.0 [skip ci]
7bfcc94 
# [1.8.0](v1.7.2...v1.8.0) (2023-06-18)

### Features

* add stats dto to collection item ([a9643e8](a9643e8)), closes [#46](#46)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@darekkay
Copy link

Thank you very much for such a quick fix! It all works fine for me now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LearningProcesss LearningProcesss

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add conditiontext and stats to collection LearningProcesss/boardgamegeekjsclient
3 participants
@ericpoulinnz @darekkay @LearningProcesss