Remove mut when using show() for sync Nbgl object

Author: yogh333

ledger_device_sdk/src/nbgl.rs

@@ -77,7 +77,7 @@ trait SyncNBGL: Sized {
         }
     }
 
-    fn ux_sync_wait(&mut self, exit_on_apdu: bool) -> SyncNbgl {
+    fn ux_sync_wait(&self, exit_on_apdu: bool) -> SyncNbgl {
         unsafe {
             if let Some(comm) = COMM_REF.as_mut() {
                 while !G_ENDED {

ledger_device_sdk/src/nbgl/nbgl_address_review.rs

@@ -31,7 +31,7 @@ impl<'a> NbglAddressReview<'a> {
         }
     }
 
-    pub fn show(&mut self, address: &str) -> bool {
+    pub fn show(&self, address: &str) -> bool {
         unsafe {
             let icon: nbgl_icon_details_t = match self.glyph {
                 Some(g) => g.into(),

ledger_device_sdk/src/nbgl/nbgl_choice.rs

@@ -22,7 +22,7 @@ impl<'a> NbglChoice<'a> {
     }
 
     pub fn show(
-        &mut self,
+        &self,
         message: &str,
         sub_message: &str,
         confirm_text: &str,

ledger_device_sdk/src/nbgl/nbgl_generic_review.rs

@@ -111,8 +111,8 @@ impl InfoButton {
 /// using the NbglGenericReview struct.
 pub struct TagValueList {
     pairs: Vec<nbgl_contentTagValue_t>,
-    items: Vec<CString>,
-    values: Vec<CString>,
+    _items: Vec<CString>,
+    _values: Vec<CString>,
     nb_max_lines_for_value: u8,
     small_case_for_value: bool,
     wrapping: bool,
@@ -142,8 +142,8 @@ impl TagValueList {
         }
         TagValueList {
             pairs: c_field_strings,
-            items: c_field_names,
-            values: c_field_values,
+            _items: c_field_names,
+            _values: c_field_values,
             nb_max_lines_for_value,
             small_case_for_value,
             wrapping,
@@ -199,7 +199,7 @@ impl TagValueConfirm {
 /// when using the NbglGenericReview struct.
 pub struct InfosList {
     info_types_cstrings: Vec<CString>,
-    info_contents_cstrings: Vec<CString>,
+    _info_contents_cstrings: Vec<CString>,
     info_types_ptr: Vec<*const c_char>,
     info_contents_ptr: Vec<*const c_char>,
 }
@@ -220,7 +220,7 @@ impl InfosList {
             info_contents_cstrings.iter().map(|s| s.as_ptr()).collect();
         InfosList {
             info_types_cstrings: info_types_cstrings,
-            info_contents_cstrings: info_contents_cstrings,
+            _info_contents_cstrings: info_contents_cstrings,
             info_types_ptr: info_types_ptr,
             info_contents_ptr: info_contents_ptr,
         }
@@ -413,7 +413,7 @@ impl NbglGenericReview {
             .collect()
     }
 
-    pub fn show(&mut self, reject_button_str: &str) -> bool {
+    pub fn show(&self, reject_button_str: &str) -> bool {
         unsafe {
             let c_content_list: Vec<nbgl_content_t> = self.to_c_content_list();
 

ledger_device_sdk/src/nbgl/nbgl_review.rs

@@ -57,7 +57,7 @@ impl<'a> NbglReview<'a> {
         }
     }
 
-    pub fn show(&mut self, fields: &[Field]) -> bool {
+    pub fn show(&self, fields: &[Field]) -> bool {
         unsafe {
             let v: Vec<CField> = fields
                 .iter()

ledger_device_sdk/src/nbgl/nbgl_review_status.rs

@@ -19,7 +19,7 @@ impl<'a> NbglReviewStatus {
         NbglReviewStatus { status_type }
     }
 
-    pub fn show(&mut self, success: bool) {
+    pub fn show(&self, success: bool) {
         unsafe {
             self.ux_sync_init();
             nbgl_useCaseReviewStatus(self.status_type.to_message(success), Some(quit_callback));

ledger_device_sdk/src/nbgl/nbgl_status.rs

@@ -21,7 +21,7 @@ impl NbglStatus {
         }
     }
 
-    pub fn show(&mut self, success: bool) {
+    pub fn show(&self, success: bool) {
         unsafe {
             self.ux_sync_init();
             nbgl_useCaseStatus(

ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs

@@ -37,7 +37,7 @@ impl NbglStreamingReview {
         }
     }
 
-    pub fn start(&mut self, title: &str, subtitle: &str) -> bool {
+    pub fn start(&self, title: &str, subtitle: &str) -> bool {
         unsafe {
             let title = CString::new(title).unwrap();
             let subtitle = CString::new(subtitle).unwrap();
@@ -77,7 +77,7 @@ impl NbglStreamingReview {
         }
     }
 
-    pub fn continue_review(&mut self, fields: &[Field]) -> bool {
+    pub fn continue_review(&self, fields: &[Field]) -> bool {
         unsafe {
             let v: Vec<CField> = fields
                 .iter()
@@ -124,7 +124,7 @@ impl NbglStreamingReview {
         }
     }
 
-    pub fn finish(&mut self, finish_title: &str) -> bool {
+    pub fn finish(&self, finish_title: &str) -> bool {
         unsafe {
             let finish_title = CString::new(finish_title).unwrap();