Merge pull request #283 from LedgerHQ/long-apdu-encoding

yogh333 · web-flow · commit 52b20ab461e6 · 2025-08-26T11:36:47.000+02:00
Use big-endian for long APDUs data length in header
diff --git a/ledger_device_sdk/src/io.rs b/ledger_device_sdk/src/io.rs
@@ -618,7 +618,7 @@ impl Comm {
                 (0, 6) => Err(StatusWords::BadLen),
                 (0, _) => {
                     let len =
-                        u16::from_le_bytes([self.apdu_buffer[5], self.apdu_buffer[6]]) as usize;
+                        u16::from_be_bytes([self.apdu_buffer[5], self.apdu_buffer[6]]) as usize;
                     get_data_from_buffer(len, 7)
                 }
                 (len, _) => get_data_from_buffer(len, 5),

Original file line number	Diff line number	Diff line change
`@@ -618,7 +618,7 @@ impl Comm {`
`618`	`618`	`(0, 6) => Err(StatusWords::BadLen),`
`619`	`619`	`(0, _) => {`
`620`	`620`	`let len =`
`621`		`- u16::from_le_bytes([self.apdu_buffer[5], self.apdu_buffer[6]]) as usize;`
	`621`	`+ u16::from_be_bytes([self.apdu_buffer[5], self.apdu_buffer[6]]) as usize;`
`622`	`622`	`get_data_from_buffer(len, 7)`
`623`	`623`	`}`
`624`	`624`	`(len, _) => get_data_from_buffer(len, 5),`