Update after PR review

Author: yogh333

.github/workflows/get_rust_apps.py

@@ -8,10 +8,15 @@
     print("Usage: get_rust_apps.py <github_token>")
     sys.exit(1)
 
-ledger_devices = ["nanos+", "nanox", "stax", "flex"]
-filtered_apps = ["app-kadena-legacy", "app-pocket"]
+# Excluded Rust apps
+# app-kadena-legacy: has been replaced by app-kadena
+# app-pocket: does not build (Obsidians' Alamgu issue)
+excluded_apps = ["app-kadena-legacy", "app-pocket"]
 
-# Retrieve all apps on LedgerHQ GitHub organization
+# Excluded devices
+excluded_devices = ["nanos"]
+
+# Retrieve all public apps on LedgerHQ GitHub organization
 token = sys.argv[1]
 gh = GitHubLedgerHQ(token)
 apps=gh.apps.filter(archived=Condition.WITHOUT)
@@ -29,20 +34,11 @@
     else:
         # Filter out apps that are Rust based
         if manifest.app.sdk == "rust":
-                rust_apps.append(app.name)
-                # filter out app for specific devices
-                for d in ledger_devices:
-                    if d not in manifest.app.devices or app.name in filtered_apps:
-                        exclude_apps.append({"app-name": app.name, "device": d})
+            if app.name not in excluded_apps:
+                for d in manifest.app.devices:
+                    if d not in excluded_devices:
+                        rust_apps.append({"app-name": app.name, "device": d})
 
-# save the list of Rust apps in a json format:
+# save the list of (apps, device) pairs to build in a json format:
 with open("rust_apps.json", "w") as f:
-    f.write(json.dumps(rust_apps))
-
-# save the list of Excluded apps in a json format:
-with open("exclude_apps.json", "w") as f:
-    f.write(json.dumps(exclude_apps))
-
-# save the list of Ledger devices in a json format:
-with open("ledger_devices.json", "w") as f:
-    f.write(json.dumps(ledger_devices))
+    f.write(json.dumps(rust_apps))

.github/workflows/reusable_build_all_apps.yml

@@ -31,54 +31,48 @@ jobs:
               echo "repo=${{ github.repository}}" >> $GITHUB_OUTPUT
               echo "branch=${{ github.ref }}" >> $GITHUB_OUTPUT
             fi      
-    # retrieve-rust-apps:
-    #   name: Retrieve Rust Apps
-    #   runs-on: ubuntu-latest
-    #   needs: how-workflow-is-called
-    #   outputs:
-    #     rust_apps: ${{ steps.get_rust_apps.outputs.rust_apps }}
-    #   steps:
-    #     - name: Checkout repository
-    #       uses: actions/checkout@v4
-    #       with:
-    #         repository: ${{ needs.how-workflow-is-called.outputs.repository }}
-    #         ref: ${{ needs.how-workflow-is-called.outputs.branch }}
-    #     - name: Set up Python
-    #       uses: actions/setup-python@v4
-    #       with:
-    #           python-version: '3.x'
-    #     - name: Install ledgered
-    #       run: pip install ledgered
-    #     - name: Get all rust apps
-    #       id: get_rust_apps
-    #       run: |
-    #         python .github/workflows/get_rust_apps.py ${{ secrets.GITHUB_TOKEN }}
-    #         echo "rust_apps=$(cat rust_apps.json)" >> $GITHUB_OUTPUT
+    retrieve-rust-apps:
+      name: Retrieve Rust Apps
+      runs-on: ubuntu-latest
+      needs: how-workflow-is-called
+      outputs:
+        rust_apps: ${{ steps.get_rust_apps.outputs.rust_apps }}
+      steps:
+        - name: Checkout repository
+          uses: actions/checkout@v4
+          with:
+            repository: ${{ needs.how-workflow-is-called.outputs.repository }}
+            ref: ${{ needs.how-workflow-is-called.outputs.branch }}
+        - name: Set up Python
+          uses: actions/setup-python@v4
+          with:
+              python-version: '3.x'
+        - name: Install ledgered
+          run: pip install ledgered
+        - name: Get all rust apps
+          id: get_rust_apps
+          run: |
+            python .github/workflows/get_rust_apps.py ${{ secrets.GITHUB_TOKEN }}
+            echo "rust_apps=$(cat rust_apps.json)" >> $GITHUB_OUTPUT
 
-    # display-rust-apps:
-    #   name: Display Rust Apps
-    #   runs-on: ubuntu-latest
-    #   needs: retrieve-rust-apps
-    #   steps:
-    #     - name: Display Rust Apps
-    #       run: |
-    #         echo "Rust apps: ${{ needs.retrieve-rust-apps.outputs.rust_apps }}"
+    display-rust-apps:
+      name: Display Rust Apps
+      runs-on: ubuntu-latest
+      needs: retrieve-rust-apps
+      steps:
+        - name: Display Rust Apps
+          run: |
+            echo "Rust apps: ${{ needs.retrieve-rust-apps.outputs.rust_apps }}"
 
     test-build:
         name: Build for all targets
-        # needs: [retrieve-rust-apps, how-workflow-is-called]
-        needs: [how-workflow-is-called]
+        needs: [retrieve-rust-apps, how-workflow-is-called]
         strategy:
             fail-fast: false
             matrix:
-              app-name: []
-              device: []
-              # include: ${{ fromJSON(needs.retrieve-rust-apps.outputs.rust_apps) }}
-              include:
-                - app-name: "app-boilerplate-rust"
-                  device: "nanos+"
-                - app-name: "app-starknet"
-                  device: "nanos+"
+              app-name: ["app-boilerplate-rust"]
+              device: ["nanos+", "nanox", "stax", "flex"]
+              include: ${{ fromJSON(needs.retrieve-rust-apps.outputs.rust_apps) }}
         runs-on: ubuntu-latest
         container:
             image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder:latest