Few fixes

Author: yogh333

ledger_device_sdk/src/ecc.rs

@@ -189,7 +189,7 @@ impl<const N: usize, const TY: char> ECPrivateKey<N, TY> {
     /// [here](https://blog.rust-lang.org/inside-rust/2021/09/06/Splitting-const-generics.html#featuregeneric_const_exprs)
     pub fn public_key(&self) -> Result<ECPublicKey<{ Self::P }, TY>, CxError>
     where
-        [(); Self::P]:,
+        [(); Self::P]: Sized,
     {
         let mut pubkey = ECPublicKey::<{ Self::P }, TY>::new(self.curve);
         let err = unsafe {

ledger_device_sdk/src/io.rs

@@ -407,7 +407,7 @@ impl Comm {
                         G_ux_params.u.pairing_request.pairing_info_len = (_len - 2) as u32;
                         for i in 0..G_ux_params.u.pairing_request.pairing_info_len as usize {
                             G_ux_params.u.pairing_request.pairing_info[i as usize] =
-                                seph_buffer[5 + i] as i8;
+                                seph_buffer[5 + i] as u8;
                         }
                         G_ux_params.u.pairing_request.pairing_info
                             [G_ux_params.u.pairing_request.pairing_info_len as usize] = 0;

ledger_device_sdk/src/libcall/swap.rs

@@ -156,7 +156,7 @@ pub fn get_check_address_params<
     debug_print("==> GET_REF_ADDRESS\n");
     let mut address_length = 0usize;
     let mut c = unsafe { *(params.address_to_check.add(address_length)) };
-    while c != '\0' as i8 && address_length < ADDRESS_BUF_SIZE {
+    while c != '\0' as u8 && address_length < ADDRESS_BUF_SIZE {
         check_address_params.ref_address[address_length] = c as u8;
         address_length += 1;
         c = unsafe { *(params.address_to_check.add(address_length)) };
@@ -224,7 +224,7 @@ pub fn get_printable_amount_params<
     debug_print("==> GET_AMOUNT_STR\n");
     printable_amount_params.amount_str = unsafe {
         &(*(libarg.__bindgen_anon_1.get_printable_amount as *mut get_printable_amount_parameters_t))
-            .printable_amount as *const i8 as *mut i8
+            .printable_amount as *const u8 as *mut i8
     };
 
     printable_amount_params
@@ -285,7 +285,7 @@ pub fn sign_tx_params<const COIN_CONFIG_BUF_SIZE: usize, const ADDRESS_BUF_SIZE:
     debug_print("==> GET_DESTINATION_ADDRESS\n");
     let mut dest_address_length = 0usize;
     let mut c = unsafe { *params.destination_address.add(dest_address_length) };
-    while c != '\0' as i8 && dest_address_length < ADDRESS_BUF_SIZE {
+    while c != '\0' as u8 && dest_address_length < ADDRESS_BUF_SIZE {
         create_tx_params.dest_address[dest_address_length] = c as u8;
         dest_address_length += 1;
         c = unsafe { *params.destination_address.add(dest_address_length) };

ledger_device_sdk/src/nbgl/nbgl_review.rs

@@ -80,8 +80,8 @@ impl<'a> NbglReview<'a> {
             let mut tag_value_array: Vec<nbgl_contentTagValue_t> = Vec::new();
             for field in v.iter() {
                 let val = nbgl_contentTagValue_t {
-                    item: field.name.as_ptr() as *const i8,
-                    value: field.value.as_ptr() as *const i8,
+                    item: field.name.as_ptr() as *const ::core::ffi::c_char,
+                    value: field.value.as_ptr() as *const ::core::ffi::c_char,
                     ..Default::default()
                 };
                 tag_value_array.push(val);

ledger_device_sdk/src/nbgl/nbgl_streaming_review.rs

@@ -101,8 +101,8 @@ impl NbglStreamingReview {
             let mut tag_value_array: Vec<nbgl_contentTagValue_t> = Vec::new();
             for field in v.iter() {
                 let val = nbgl_contentTagValue_t {
-                    item: field.name.as_ptr() as *const i8,
-                    value: field.value.as_ptr() as *const i8,
+                    item: field.name.as_ptr() as *const ::core::ffi::c_char,
+                    value: field.value.as_ptr() as *const ::core::ffi::c_char,
                     ..Default::default()
                 };
                 tag_value_array.push(val);

rust-toolchain.toml

@@ -1,2 +1,2 @@
 [toolchain]
-channel = "nightly-2024-12-01"
+channel = "nightly"