Fix Tooltip crash or bad display

Author: cedelavergne-ledger

lib_nbgl/src/nbgl_use_case.c

@@ -2271,10 +2271,10 @@ static void initWarningTipBox(const nbgl_tipBox_t *tipBox)
     }
 
     if ((tipBox != NULL) || (predefinedTipBoxText != NULL)) {
-        genericContext.validWarningCtx = true;
         // do not display "Swipe to review" if a tip-box is displayed
         STARTING_CONTENT.content.extendedCenter.contentCenter.subText = NULL;
         if (predefinedTipBoxText != NULL) {
+            genericContext.validWarningCtx                      = true;
             STARTING_CONTENT.content.extendedCenter.tipBox.icon = NULL;
             STARTING_CONTENT.content.extendedCenter.tipBox.text = predefinedTipBoxText;
         }
@@ -3569,6 +3569,7 @@ void nbgl_useCaseAdvancedReview(nbgl_operationType_t              operationType,
                                 const nbgl_warning_t             *warning,
                                 nbgl_choiceCallback_t             choiceCallback)
 {
+    memset(&reviewWithWarnCtx, 0, sizeof(reviewWithWarnCtx));
     // memorize tipBox because it can be in the call stack of the caller
     if (tipBox != NULL) {
         memcpy(&activeTipBox, tipBox, sizeof(activeTipBox));
@@ -3599,7 +3600,6 @@ void nbgl_useCaseAdvancedReview(nbgl_operationType_t              operationType,
         operationType |= RISKY_OPERATION;
     }
 
-    memset(&reviewWithWarnCtx, 0, sizeof(reviewWithWarnCtx));
     reviewWithWarnCtx.isStreaming    = false;
     reviewWithWarnCtx.operationType  = operationType;
     reviewWithWarnCtx.tagValueList   = tagValueList;